-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(ui): live usage indicator, child trace spans, cancel subscription modal z-index #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant useWorkflowExecution
participant ExecutionStream
participant WorkflowStore
participant ExecutionStore
participant Console
participant Server
participant QueryClient
User->>useWorkflowExecution: "handleRunWorkflow(workflowInput)"
useWorkflowExecution->>WorkflowStore: "Get workflow state"
WorkflowStore-->>useWorkflowExecution: "blocks, edges"
useWorkflowExecution->>ExecutionStore: "setIsExecuting(true)"
useWorkflowExecution->>useWorkflowExecution: "executeWorkflow()"
useWorkflowExecution->>useWorkflowExecution: "Resolve triggers and validate"
useWorkflowExecution->>ExecutionStream: "execute({workflowId, input, startBlockId})"
ExecutionStream->>Server: "POST /api/workflows/execute"
Server-->>ExecutionStream: "Stream response"
loop For each streaming event
ExecutionStream->>useWorkflowExecution: "onBlockStarted(blockData)"
useWorkflowExecution->>ExecutionStore: "setActiveBlocks(blockId)"
useWorkflowExecution->>ExecutionStore: "setEdgeRunStatus(edgeId, 'success')"
ExecutionStream->>useWorkflowExecution: "onBlockCompleted(blockData)"
useWorkflowExecution->>ExecutionStore: "setBlockRunStatus(blockId, 'success')"
useWorkflowExecution->>Console: "addConsole(blockResult)"
alt If streaming block
ExecutionStream->>useWorkflowExecution: "onStreamChunk(data)"
end
end
ExecutionStream->>useWorkflowExecution: "onExecutionCompleted(result)"
useWorkflowExecution->>useWorkflowExecution: "setExecutionResult(result)"
useWorkflowExecution->>QueryClient: "invalidateQueries(subscriptionKeys)"
useWorkflowExecution->>ExecutionStore: "setIsExecuting(false)"
useWorkflowExecution->>ExecutionStore: "setActiveBlocks(new Set())"
useWorkflowExecution-->>User: "Return execution result"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
apps/sim/hooks/queries/organization.ts, line 82 (link)syntax: Use logger.error instead of console.error as per project guidelines
24 files reviewed, 5 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
...im/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/hooks/use-usage-limits.ts
Show resolved
Hide resolved
...im/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/hooks/use-usage-limits.ts
Show resolved
Hide resolved
...rkspace/[workspaceId]/w/components/sidebar/components-new/usage-indicator/rotating-digit.tsx
Outdated
Show resolved
Hide resolved
...kspace/[workspaceId]/w/components/sidebar/components-new/usage-indicator/usage-indicator.tsx
Show resolved
Hide resolved
… modal z-index (#2044) * cleanup * show trace spans for child blocks that error * fix z index for cancel subscription popup * rotating digit live usage indicator * fix * remove unused code * fix type * fix(billing): fix team upgrade * fix * fix tests --------- Co-authored-by: waleed <walif6@gmail.com>
* standardized delete modals * fix * fix(ui): live usage indicator, child trace spans, cancel subscription modal z-index (#2044) * cleanup * show trace spans for child blocks that error * fix z index for cancel subscription popup * rotating digit live usage indicator * fix * remove unused code * fix type * fix(billing): fix team upgrade * fix * fix tests --------- Co-authored-by: waleed <walif6@gmail.com> * remove unused barrel exports * remove unused components --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Summary
Multiple UI fixes.
Type of Change
Testing
Tested manually
Checklist