Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • add option to disable error notifications, notifications like permissions and trigger errors still remain non-optional since they are informational
  • remove deprecated autoFillEnvVars field

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 19, 2025 0:25am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Adds user setting to disable block execution error notifications (permissions/trigger errors remain non-optional)
  • Removes deprecated autoFillEnvVars field from database and API layer

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Clean implementation with proper database migration, consistent default values (true), and correct conditional logic that preserves informational notifications
  • No files require special attention

Important Files Changed

Filename Overview
packages/db/migrations/0110_broken_paladin.sql Adds error_notifications_enabled column with safe default (true) and removes deprecated auto_fill_env_vars column
apps/sim/stores/terminal/console/store.ts Conditionally shows error notifications based on user setting while maintaining informational trigger/permission errors
apps/sim/app/api/users/me/settings/route.ts Adds errorNotificationsEnabled to API schema/defaults, removes deprecated autoFillEnvVars field

Sequence Diagram

sequenceDiagram
    participant User
    participant UI as "Settings Modal"
    participant API as "Settings API"
    participant DB as "Database"
    participant Store as "Zustand Store"
    participant Console as "Console Store"
    participant NotifStore as "Notification Store"

    User->>UI: "Toggle error notifications"
    UI->>API: "PATCH /api/users/me/settings {errorNotificationsEnabled: false}"
    API->>DB: "UPDATE settings SET error_notifications_enabled = false"
    DB-->>API: "Success"
    API-->>UI: "Updated settings"
    UI->>Store: "syncSettingsToZustand({isErrorNotificationsEnabled: false})"
    
    Note over Console,NotifStore: "Later, when block execution fails"
    
    Console->>Console: "addConsole(entry with error)"
    Console->>Store: "getState().isErrorNotificationsEnabled"
    Store-->>Console: "false"
    Console->>Console: "Skip addNotification call"
    Note over Console: "Error logged to console only"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@waleedlatif1 waleedlatif1 merged commit 3faab2c into staging Nov 19, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/notifs branch November 19, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants