-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(subflows): add loops/parallels to accessible list of blocks in the tag dropdown when contained withitn a subflow #2047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile Summary
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant TagDropdown
participant Hook as useAccessibleReferencePrefixes
participant Store as WorkflowStore
participant Resolver as LoopResolver
User->>TagDropdown: Open tag dropdown in subflow block
TagDropdown->>Hook: Call hook with blockId
Hook->>Store: Get loops, parallels, blocks, edges
Store-->>Hook: Return workflow data
Hook->>Hook: Find containing loop/parallel
Hook->>Hook: Add loop.id to accessibleIds
Hook->>Hook: Add parallel.id to accessibleIds
Hook-->>TagDropdown: Return accessible prefixes (including loop/parallel)
TagDropdown->>TagDropdown: Build tag list with "index" tag
TagDropdown-->>User: Display tags (loop.index, loop.currentItem, etc.)
User->>TagDropdown: Select "index" tag
TagDropdown->>TagDropdown: Process tag as "loop.index"
TagDropdown-->>User: Insert "<loop.index>" reference
Note over Resolver: At runtime, loop.index resolves to loopScope.iteration
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
…e tag dropdown when contained withitn a subflow
076e1ec to
7712837
Compare
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Summary
add loops/parallels to accessible list of blocks in the tag dropdown when contained within a subflow
Type of Change
Testing
Tested manually
Checklist