Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

added blacksmith optimizations to workflows and dockerfiles to enhance performance. please review before pushing to production

Type of Change

  • Other: Performance

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…e performance. please review before pushing to production
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 19, 2025 8:59pm

@waleedlatif1 waleedlatif1 changed the title improvement(runners): added blacksmith optimizations to workflows and dockerfiles to enhance performance. please review before pushing to production improvement(runners): added blacksmith optimizations to workflows and dockerfiles to enhance performance Nov 19, 2025
@waleedlatif1 waleedlatif1 marked this pull request as ready for review November 19, 2025 20:32
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Added Blacksmith runner optimizations including Docker build cache configuration (cache-from/cache-to) for workflows and Bun dependency caching across CI/CD pipelines
  • Restructured Dockerfiles to optimize layer caching by reordering COPY commands to place frequently-changing files last and removing duplicate dependency installations

Confidence Score: 4/5

  • This PR is safe to merge with minor optimization opportunities
  • Score reflects well-structured performance optimizations with proper caching strategies; minor improvement possible for empty cache-from handling on staging branch
  • Pay attention to .github/workflows/ci.yml and .github/workflows/images.yml for cache-from configuration on staging branch

Important Files Changed

Filename Overview
.github/workflows/ci.yml Added Docker build cache configuration with cache-from and cache-to for AMD64 and ARM64 builds
.github/workflows/images.yml Added Docker build cache configuration with cache-from and cache-to for AMD64 and ARM64 builds
docker/app.Dockerfile Optimized layer caching by reordering COPY commands and removing duplicate bun install in builder stage

Sequence Diagram

sequenceDiagram
    participant Dev as "Developer"
    participant GH as "GitHub Actions"
    participant Cache as "Registry Cache"
    participant ECR as "Amazon ECR"
    participant GHCR as "GitHub Container Registry"
    
    Dev->>GH: "Push to main/staging"
    GH->>GH: "Run test-build workflow"
    GH->>Cache: "Cache Bun dependencies"
    GH->>GH: "Build AMD64 images"
    GH->>Cache: "Pull cache-from registry"
    GH->>ECR: "Push images with tag (latest/staging)"
    GH->>GHCR: "Push AMD64 images (main only)"
    GH->>Cache: "Save cache-to inline"
    
    alt Main branch only
        GH->>GH: "Build ARM64 images"
        GH->>Cache: "Pull cache-from registry"
        GH->>GHCR: "Push ARM64 images"
        GH->>Cache: "Save cache-to inline"
        GH->>GHCR: "Create multi-arch manifests"
    end
    
    GH->>GH: "Deploy to Trigger.dev"
    GH->>GH: "Process docs embeddings"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@waleedlatif1 waleedlatif1 merged commit 570b8d6 into staging Nov 19, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the blacksmith-optimizations branch November 19, 2025 21:07
waleedlatif1 added a commit that referenced this pull request Nov 20, 2025
… dockerfiles to enhance performance (#2055)

* added blacksmith optimizations to workflows and dockerfiles to enhance performance. please review before pushing to production

* remove cache from and cache to directives from docker based actions, per blacksmith docs

---------

Co-authored-by: Connor Mulholland <connormul@Connors-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants