Skip to content

Conversation

@aadamgough
Copy link
Contributor

Summary

Added add worksheet

Type of Change

  • New feature

Testing

manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 20, 2025 1:36am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Summary

  • Adds new worksheet_add operation to Microsoft Excel integration for creating worksheets in workbooks
  • Implements comprehensive validation for worksheet names (31 character limit, invalid character checks)
  • Includes complete integration across tool definition, block configuration, type definitions, registry, and documentation

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Clean implementation following established patterns, proper validation and error handling, comprehensive test coverage through manual testing, and complete documentation updates.
  • No files require special attention.

Important Files Changed

Filename Overview
apps/sim/tools/microsoft_excel/worksheet_add.ts New tool implementation for adding worksheets to Excel workbooks with proper validation, error handling, and follows established patterns
apps/sim/blocks/blocks/microsoft_excel.ts Integrated worksheet add operation into block configuration with proper UI fields, validation, and tool mapping

Sequence Diagram

sequenceDiagram
    participant User
    participant Block as "Microsoft Excel Block"
    participant Tool as "Worksheet Add Tool"
    participant API as "Microsoft Graph API"
    
    User->>Block: "Add Worksheet" operation with worksheetName
    Block->>Block: Validate worksheetName is provided
    Block->>Tool: Call microsoft_excel_worksheet_add
    Tool->>Tool: Validate worksheet name (length, invalid chars)
    Tool->>API: "POST /workbook/worksheets/add"
    API-->>Tool: Worksheet data (id, name, position)
    Tool->>API: "GET /drive/items/{id}" (fetch webUrl)
    API-->>Tool: Spreadsheet webUrl
    Tool-->>Block: Return worksheet details + metadata
    Block-->>User: Success with worksheet info
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@waleedlatif1 waleedlatif1 changed the title Improvement(excel): added add worksheet improvement(tools): added add worksheet to excel block Nov 20, 2025
@aadamgough aadamgough force-pushed the improvement/excel-upgrade branch from 057b290 to 08cd182 Compare November 20, 2025 01:34
@waleedlatif1 waleedlatif1 merged commit 3647a3e into staging Nov 20, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/excel-upgrade branch November 20, 2025 01:34
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 20, 2025
10 tasks
waleedlatif1 pushed a commit that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants