improvement(store-hydration): refactor loading state tracking for workflows

[icecrasher321]

Summary

Refactor loading state tracking for workflows to be based on simple state machine.

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 20, 2025 3:04am

[greptile-apps]

Greptile Summary

• Refactored workflow loading to use a state machine pattern with explicit phases (idle, metadata-loading, metadata-ready, state-loading, ready, error)
• Implemented race condition prevention using request IDs to discard stale workflow hydration results
• Removed boolean isLoading flag in favor of comprehensive HydrationState tracking across workspace and workflow contexts

Confidence Score: 4/5

• Safe to merge with minor areas requiring attention in race condition edge cases
• Well-structured state machine refactoring with proper race condition handling via request IDs, though the completeMetadataLoad transition logic could be more explicit about handling concurrent state loads
• apps/sim/stores/workflows/registry/store.ts - verify the state transition logic in completeMetadataLoad when phase is state-loading

Important Files Changed

Filename	Overview
apps/sim/stores/workflows/registry/store.ts	Refactored loading state to use state machine pattern with request IDs for race condition prevention
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx	Replaced local state with computed isWorkflowReady based on hydration phase and removed redundant effect

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowHook as "useWorkflows Hook"
    participant Registry as "Workflow Registry"
    participant API as "API /workflows"
    participant Store as "Workflow Store"

    User->>WorkflowHook: Navigate to workspace
    WorkflowHook->>Registry: beginMetadataLoad(workspaceId)
    Registry->>Registry: Set phase='metadata-loading'
    WorkflowHook->>API: GET /api/workflows?workspaceId
    API-->>WorkflowHook: Return workflow list
    WorkflowHook->>Registry: completeMetadataLoad(workspaceId, workflows)
    Registry->>Registry: Set phase='metadata-ready'
    User->>Registry: setActiveWorkflow(workflowId)
    Registry->>Registry: loadWorkflowState(workflowId)
    Registry->>Registry: Set phase='state-loading', create requestId
    Registry->>API: GET /api/workflows/:id
    API-->>Registry: Return workflow state
    Registry->>Registry: Validate requestId matches
    Registry->>Store: setState(workflowState)
    Registry->>Registry: Set phase='ready'
    Registry-->>User: Workflow ready

Loading

[greptile-apps]

_{5 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format}