Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • update sitemap and fix loading strat on blogs to prevent mobile crash

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 20, 2025 3:57am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Summary

  • Added responsive image sizes and lazy loading to blog pages to prevent mobile crashes
  • Enhanced sitemap with proper priorities and timestamps for better SEO
  • Added @tailwindcss/typography plugin for improved prose styling

Confidence Score: 3/5

  • This PR has one critical issue with sitemap URLs that will 404
  • The image optimization changes are solid and address the mobile crash issue effectively. However, the sitemap adds tag page URLs without corresponding routes, which will cause 404 errors for crawlers
  • Pay close attention to apps/sim/app/sitemap.ts - the tag pages need routes created or should be removed from sitemap

Important Files Changed

Filename Overview
apps/sim/app/sitemap.ts Enhanced sitemap with static page dates, priorities, and tag pages, but tag pages may not have routes

Sequence Diagram

sequenceDiagram
    participant User
    participant Browser
    participant NextJS as "Next.js Server"
    participant BlogRegistry as "Blog Registry"
    participant MDX as "MDX Compiler"
    
    User->>Browser: "Navigate to /studio"
    Browser->>NextJS: "Request blog index page"
    NextJS->>BlogRegistry: "getAllPostMeta()"
    BlogRegistry-->>NextJS: "Return posts metadata"
    NextJS->>Browser: "Render page with images (lazy loading, responsive sizes)"
    Browser->>Browser: "Load images progressively based on viewport"
    
    User->>Browser: "Click blog post"
    Browser->>NextJS: "Request /studio/[slug]"
    NextJS->>BlogRegistry: "getPostBySlug(slug)"
    BlogRegistry->>MDX: "Compile MDX content"
    MDX-->>BlogRegistry: "Compiled content with components"
    BlogRegistry-->>NextJS: "Return post data"
    NextJS->>Browser: "Render article with optimized images"
    Browser->>Browser: "Load hero image (priority), lazy load related posts"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@waleedlatif1 waleedlatif1 merged commit 7c5d625 into staging Nov 20, 2025
4 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/stt branch November 20, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants