-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(linear): update required fields for linear #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile Summary
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant LinearTool
participant LinearAPI
User->>LinearTool: Call Linear operation (e.g., create_issue)
LinearTool->>LinearTool: Validate required fields
LinearTool->>LinearTool: Build input object (exclude null/empty optional fields)
LinearTool->>LinearAPI: Send GraphQL mutation/query
LinearAPI-->>LinearTool: Return response with data/errors
LinearTool->>LinearTool: Check for errors in response
alt Has errors
LinearTool-->>User: Return error message
else Success
LinearTool->>LinearTool: Extract result data
LinearTool-->>User: Return formatted output
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
| success: data.data.projectArchive.success, | ||
| projectId: response.ok ? data.data.projectArchive.success : '', | ||
| success: result.success, | ||
| projectId: result.entity?.id || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: result.entity?.id will always be undefined since the GraphQL query on line 40-45 doesn't request the entity field. Either add entity { id } to the query or use params.projectId here instead.
| projectId: result.entity?.id || '', | |
| projectId: params.projectId, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/tools/linear/archive_project.ts
Line: 77:77
Comment:
**logic:** `result.entity?.id` will always be undefined since the GraphQL query on line 40-45 doesn't request the `entity` field. Either add `entity { id }` to the query or use `params.projectId` here instead.
```suggestion
projectId: params.projectId,
```
How can I resolve this? If you propose a fix, please make it concise.
Summary
Type of Change
Testing
Tested all tools manually
Checklist