Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • upgrade runners, remove trigger deploy action in favor of direct integration

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 20, 2025 9:47pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Overview

Greptile Summary

Upgraded GitHub Actions runners from 4vcpu to 8vcpu and removed the trigger-deploy.yml workflow that handled Trigger.dev deployments.

  • Doubled compute resources across all workflows (blacksmith-4vcpu-ubuntu-2404blacksmith-8vcpu-ubuntu-2404)
  • Removed the trigger-deploy job from CI pipeline that deployed to Trigger.dev staging/production
  • Deleted the entire trigger-deploy.yml workflow file (55 lines removed)
  • PR claims this is in favor of "direct integration" but no new integration mechanism is visible in the diff

Confidence Score: 3/5

  • This PR has infrastructure changes that need verification before merging
  • Runner upgrades are straightforward improvements, but the removal of Trigger.dev deployment workflow raises concerns since no replacement deployment mechanism is visible in the diff. Need to verify that Trigger.dev v4 has automatic deployment capabilities or that another mechanism exists.
  • .github/workflows/ci.yml - verify deployment mechanism still works after removing trigger-deploy job

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/ci.yml 4/5 Upgraded runner from 4vcpu to 8vcpu and removed trigger-deploy job reference
.github/workflows/trigger-deploy.yml 3/5 Deleted workflow file that handled Trigger.dev deployments to staging and production

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant BB as Blacksmith Runner
    participant ECR as AWS ECR
    participant GHCR as GitHub Container Registry
    participant Docs as Docs Processing
    
    Note over GH: Push to main/staging
    
    GH->>BB: Start test-build job
    BB->>GH: Tests & build complete
    
    par Build AMD64 Images
        GH->>BB: build-amd64 (8vcpu)
        BB->>ECR: Push images with tags (latest/staging)
        BB->>GHCR: Push AMD64 images (main only)
    and Build ARM64 Images (main only)
        GH->>BB: build-ghcr-arm64 (8vcpu ARM)
        BB->>GHCR: Push ARM64 images
    end
    
    GH->>BB: create-ghcr-manifests (main only)
    BB->>GHCR: Create multi-arch manifests
    
    GH->>BB: process-docs
    BB->>Docs: Process documentation embeddings
    
    Note over GH: Trigger.dev deployment removed<br/>(previously deployed here)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. .github/workflows/ci.yml, line 201-207 (link)

    style: verify that Trigger.dev v4 has automatic deployment from docker image pushes or that there's another mechanism handling deployments - the PR description mentions "direct integration" but no new integration is visible in this diff

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 00ae718 into staging Nov 20, 2025
8 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/runners branch November 20, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants