-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(models): added claude opus 4.5 #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryAdded Claude Opus 4.5 model support with pricing and configuration. However, there is a critical model ID mismatch that will cause runtime failures. Key Changes:
Critical Issue: Required Fixes:
Confidence Score: 1/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant UI as Copilot UI
participant API as /api/copilot/chat
participant Provider as Provider Utils
participant Anthropic as Anthropic Provider
User->>UI: Select "Claude 4.5 Opus"
UI->>UI: Sets model = "claude-4.5-opus"
User->>UI: Send message
UI->>API: POST with model="claude-4.5-opus"
API->>API: Validate against enum
Note over API: ❌ Missing "claude-opus-4-5" in enum
API->>Provider: getProviderFromModel("claude-4.5-opus")
Provider->>Provider: Normalize to lowercase
Provider->>Provider: Lookup in getAllModelProviders()
Note over Provider: ❌ Model ID mismatch:<br/>UI: "claude-4.5-opus"<br/>Provider: "claude-opus-4-5"
Provider-->>API: ❌ Model not found, fallback to ollama
API->>Anthropic: ❌ Wrong provider selected
Anthropic-->>User: ❌ Runtime error
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
apps/sim/app/api/copilot/chat/route.ts, line 58 (link)logic: missing
claude-opus-4-5in enum (use the provider model ID, not the UI label)
2 files reviewed, 2 comments
| // { value: 'claude-4-sonnet', label: 'Claude 4 Sonnet' }, | ||
| { value: 'claude-4.5-sonnet', label: 'Claude 4.5 Sonnet' }, | ||
| { value: 'claude-4.5-haiku', label: 'Claude 4.5 Haiku' }, | ||
| { value: 'claude-4.5-opus', label: 'Claude 4.5 Opus' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: model ID mismatch: UI uses claude-4.5-opus but provider definition uses claude-opus-4-5 (models.ts:592). This will cause model lookups to fail.
| { value: 'claude-4.5-opus', label: 'Claude 4.5 Opus' }, | |
| { value: 'claude-opus-4-5', label: 'Claude 4.5 Opus' }, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/constants.ts
Line: 26:26
Comment:
**logic:** model ID mismatch: UI uses `claude-4.5-opus` but provider definition uses `claude-opus-4-5` (models.ts:592). This will cause model lookups to fail.
```suggestion
{ value: 'claude-opus-4-5', label: 'Claude 4.5 Opus' },
```
How can I resolve this? If you propose a fix, please make it concise.
Summary
added claude opus 4.5
Type of Change
Testing
Tested manually
Checklist