Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • update guardrails pii selector component to use emcn
  • update tool credential selector in agent to be more consistent with the general credential selector

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Dec 3, 2025 2:02am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 3, 2025

Greptile Overview

Greptile Summary

This PR updates UI components to use the EMCN design system and improves OAuth credential scope handling:

  • EMCN Migration: Migrated the guardrails PII selector button from @/components/ui/button to @/components/emcn/components with updated styling using CSS variables and custom design tokens
  • Credential Selector Enhancement: Updated tool credential selector to prioritize subblock-specific requiredScopes from the toolBlock configuration before falling back to canonical provider scopes
  • Consistent Styling: Applied consistent visual styling across components with proper dark mode support and design system variables

The changes follow the established pattern of migrating to the EMCN design system while improving configuration flexibility.

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • The changes are straightforward component updates: migrating to the EMCN design system and adding proper fallback logic for credential scopes. Both changes follow established patterns in the codebase, maintain backwards compatibility, and improve the user experience.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/grouped-checkbox-list/grouped-checkbox-list.tsx 5/5 Updated Button component to use EMCN design system with consistent styling
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx 5/5 Enhanced credential selector to respect subblock-specific requiredScopes configuration

Sequence Diagram

sequenceDiagram
    participant User
    participant GroupedCheckboxList
    participant EMCNButton
    participant Dialog
    participant ToolInput
    participant ToolCredentialSelector
    participant SubBlock

    User->>GroupedCheckboxList: Click "Configure PII Types"
    GroupedCheckboxList->>EMCNButton: Render with EMCN design system
    EMCNButton->>Dialog: Open dialog
    Dialog->>User: Display PII types selection
    User->>Dialog: Select PII entities
    Dialog->>GroupedCheckboxList: Update selected values

    User->>ToolInput: Configure tool credential
    ToolInput->>SubBlock: Check for requiredScopes
    SubBlock-->>ToolInput: Return subblock-specific scopes
    ToolInput->>ToolCredentialSelector: Pass requiredScopes (subblock or default)
    ToolCredentialSelector->>User: Display credential selector with correct scopes
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit ffd12e1 into staging Dec 3, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/subblocks branch December 3, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants