Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • fix download & clear popover staying open after pressing in floating chat

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Dec 4, 2025 9:01pm

@waleedlatif1 waleedlatif1 merged commit b54ca60 into staging Dec 4, 2025
5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/chat branch December 4, 2025 21:03
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 4, 2025

Greptile Overview

Greptile Summary

Fixed the floating chat popover menu (Download/Clear options) remaining open after clicking by removing unnecessary e.stopPropagation() calls from the PopoverItem click handlers.

  • Removed stopPropagation() from the Download PopoverItem click handler
  • Removed stopPropagation() from the Clear PopoverItem click handler
  • Both handlers already explicitly call setMoreMenuOpen(false) to close the popover
  • Change aligns with existing patterns in panel.tsx where similar PopoverItem handlers work without stopPropagation()

Confidence Score: 5/5

  • This PR is safe to merge - it's a minimal, targeted bug fix that follows established patterns in the codebase.
  • The change is very small (removing 4 lines), straightforward, and follows existing patterns already used elsewhere in the codebase (panel.tsx). The fix addresses a clear UI bug without changing any logic or introducing new functionality.
  • No files require special attention.

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx 5/5 Removed unnecessary e.stopPropagation() from PopoverItem click handlers to fix popover not closing; aligns with existing patterns in codebase.

Sequence Diagram

sequenceDiagram
    participant User
    participant PopoverItem
    participant Popover
    participant ChatState

    User->>PopoverItem: Click Download/Clear
    Note over PopoverItem: Before fix: stopPropagation()<br/>prevented normal event flow
    PopoverItem->>ChatState: setMoreMenuOpen(false)
    PopoverItem->>Popover: Event bubbles (after fix)
    Popover->>Popover: Closes properly
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants