-
Notifications
You must be signed in to change notification settings - Fork 3.2k
v0.5.19: copilot fix #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.5.19: copilot fix #2219
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR adds support for integration tools (server-side executed tools) in the copilot with an "Always Allow" feature and fixes hanging tool calls. The changes introduce:
Critical Issues Found:
Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant ToolCallComponent as ToolCall Component
participant Store as Copilot Store
participant API as Backend API
participant Agent as Sim Agent
Note over User,Agent: Integration Tool Execution Flow (Allow)
User->>ToolCallComponent: Clicks "Allow" button
ToolCallComponent->>ToolCallComponent: setIsProcessing(true)
ToolCallComponent->>ToolCallComponent: setButtonsHidden(true)
ToolCallComponent->>ToolCallComponent: handleRun()
ToolCallComponent->>ToolCallComponent: Check isIntegrationTool()
ToolCallComponent->>Store: executeIntegrationTool(toolCallId)
Store->>Store: Update state to "executing"
Store->>API: POST /api/copilot/execute-tool
API->>Agent: Forward tool execution request
Agent-->>API: Return execution result
API-->>Store: Return success/failure
Store->>Store: Update state to "success" or "error"
Store-->>ToolCallComponent: Execution complete
ToolCallComponent->>ToolCallComponent: setIsProcessing(false)
Note over User,Agent: Integration Tool Skip Flow
User->>ToolCallComponent: Clicks "Skip" button
ToolCallComponent->>ToolCallComponent: handleSkip()
ToolCallComponent->>ToolCallComponent: Check isIntegrationTool()
ToolCallComponent->>Store: setToolCallState(rejected)
ToolCallComponent->>API: POST /api/copilot/tools/mark-complete
Note right of ToolCallComponent: Silent failure (empty catch)
API->>Agent: Notify tool was skipped
Agent-->>API: Acknowledge
Note over User,Agent: Always Allow Flow
User->>ToolCallComponent: Clicks "Always Allow"
ToolCallComponent->>ToolCallComponent: setIsProcessing(true)
ToolCallComponent->>ToolCallComponent: setButtonsHidden(true)
ToolCallComponent->>Store: addAutoAllowedTool(toolName)
Store->>API: POST /api/copilot/auto-allowed-tools
API->>Store: Tool added to allow list
ToolCallComponent->>Store: executeIntegrationTool(toolCallId)
Store->>API: POST /api/copilot/execute-tool
API->>Agent: Execute tool
Agent-->>Store: Result
Store-->>ToolCallComponent: Complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 3 comments
...aceId]/w/[workflowId]/components/panel/components/copilot/components/tool-call/tool-call.tsx
Outdated
Show resolved
Hide resolved
...aceId]/w/[workflowId]/components/panel/components/copilot/components/tool-call/tool-call.tsx
Show resolved
Hide resolved
...aceId]/w/[workflowId]/components/panel/components/copilot/components/tool-call/tool-call.tsx
Show resolved
Hide resolved
* Fix copilot tool call flash * Fix lint
fix(copilot): fix hanging tool calls (#2218)
fix(copilot): fix tool call flash (#2221)
fix(copilot): fix function execute tool (#2222)