Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • added searchbox to the operation dropdown for all blocks

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Dec 9, 2025 4:51am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 9, 2025

Greptile Overview

Greptile Summary

Added search functionality to operation dropdowns across all blocks by conditionally enabling the searchable prop when subBlockId === 'operation'. The implementation passes both searchable and searchPlaceholder props to the underlying Combobox component, which already has built-in search support. Removed an unnecessary comment about fetching options on dropdown open.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is minimal, well-scoped, and leverages existing Combobox functionality. The implementation correctly checks for the operation subBlockId before enabling search. No breaking changes or side effects introduced.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx 5/5 Added searchable prop to Combobox for operation subblocks, enabling search functionality with placeholder text

Sequence Diagram

sequenceDiagram
    participant User
    participant Dropdown
    participant Combobox
    
    User->>Dropdown: Opens dropdown (subBlockId='operation')
    Dropdown->>Dropdown: Check if isSearchable (subBlockId === 'operation')
    Dropdown->>Combobox: Render with searchable=true & searchPlaceholder
    Combobox->>Combobox: Render search input in dropdown
    User->>Combobox: Types search query in search box
    Combobox->>Combobox: Filter options based on search query
    Combobox->>User: Display filtered operation options
    User->>Combobox: Select filtered option
    Combobox->>Dropdown: onChange callback with selected value
    Dropdown->>Dropdown: Update state via setStoreValue
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit e390ba0 into staging Dec 9, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/dropdowns branch December 9, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants