Skip to content

fix(redis): cleanup access pattern across callsites #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Dec 10, 2025
Merged

fix(redis): cleanup access pattern across callsites #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d2c74
fix(redis): cleanup access pattern across callsites
icecrasher321 Dec 10, 2025
0749fc7
swap redis command to be non blocking
icecrasher321 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
368 changes: 164 additions & 204 deletions apps/sim/app/api/chat/[identifier]/otp/route.ts
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 7 additions & 3 deletions apps/sim/app/api/notifications/poll/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@ export async function GET(request: NextRequest) {
const requestId = nanoid()
logger.info(`Inactivity alert polling triggered (${requestId})`)

let lockAcquired = false

try {
const authError = verifyCronAuth(request, 'Inactivity alert polling')
if (authError) {
return authError
}

const locked = await acquireLock(LOCK_KEY, requestId, LOCK_TTL_SECONDS)
lockAcquired = await acquireLock(LOCK_KEY, requestId, LOCK_TTL_SECONDS)

if (!locked) {
if (!lockAcquired) {
return NextResponse.json(
{
success: true,
Expand Down Expand Up @@ -57,6 +59,8 @@ export async function GET(request: NextRequest) {
{ status: 500 }
)
} finally {
await releaseLock(LOCK_KEY).catch(() => {})
if (lockAcquired) {
await releaseLock(LOCK_KEY, requestId).catch(() => {})
}
}
}
4 changes: 3 additions & 1 deletion apps/sim/app/api/webhooks/poll/gmail/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
{ status: 500 }
)
} finally {
await releaseLock(LOCK_KEY).catch(() => {})
if (lockValue) {
await releaseLock(LOCK_KEY, lockValue).catch(() => {})
}
}
}
4 changes: 3 additions & 1 deletion apps/sim/app/api/webhooks/poll/outlook/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
{ status: 500 }
)
} finally {
await releaseLock(LOCK_KEY).catch(() => {})
if (lockValue) {
await releaseLock(LOCK_KEY, lockValue).catch(() => {})
}
}
}
4 changes: 3 additions & 1 deletion apps/sim/app/api/webhooks/poll/rss/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
{ status: 500 }
)
} finally {
await releaseLock(LOCK_KEY).catch(() => {})
if (lockValue) {
await releaseLock(LOCK_KEY, lockValue).catch(() => {})
}
}
}
Loading