Skip to content

fix(condition): fix condition block for no outgoing edge #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sg312 merged 2 commits into from
Dec 11, 2025
Merged

fix(condition): fix condition block for no outgoing edge #2306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f829e78
Fix condition block evaluation
Sg312 Dec 11, 2025
d1c7427
Lint
Sg312 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions apps/sim/executor/handlers/condition/condition-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,20 @@ export class ConditionBlockHandler implements BlockHandler {
evalContext
)

const connection = this.findConnectionForCondition(outgoingConnections, condition.id)

if (connection && conditionMet) {
return { selectedConnection: connection, selectedCondition: condition }
if (conditionMet) {
const connection = this.findConnectionForCondition(outgoingConnections, condition.id)
if (connection) {
return { selectedConnection: connection, selectedCondition: condition }
}
// Condition is true but has no outgoing edge - branch ends gracefully
logger.info(
`Condition "${condition.title}" is true but has no outgoing edge - branch ending`,
{
blockId: block.id,
conditionId: condition.id,
}
)
return { selectedConnection: null, selectedCondition: null }
}
} catch (error: any) {
logger.error(`Failed to evaluate condition "${condition.title}": ${error.message}`)
Expand Down