Skip to content

Conversation

@aadamgough
Copy link
Contributor

Summary

Fixed trello operation and telegram

Type of Change

  • Bug fix

Testing

Manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Dec 12, 2025 6:40am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 12, 2025

Greptile Overview

Greptile Summary

This PR cleans up Trello tool output schemas and fixes a Telegram document sending bug.

  • Trello tools: Removed redundant success and error output properties from 6 tool schemas and the block config. These fields are already handled by the base ToolResponse interface at the response level, making their inclusion in individual tool outputs definitions unnecessary.
  • Telegram send_document: Added defensive normalization to ensure the files parameter is always an array when provided, preventing potential runtime issues when a single file object is passed instead of an array.
  • Fixed a minor typo in the Trello block's count description (changed "boards" to "lists").

Confidence Score: 5/5

  • This PR is safe to merge - it contains straightforward schema cleanups and a defensive bug fix with no risk of breaking changes.
  • The changes are minimal and low-risk: removing redundant output schema fields that don't affect runtime behavior, and adding array normalization that only improves robustness. The ToolResponse interface already handles success and error at the response level, so removing these from individual tool output definitions is a correct cleanup.
  • No files require special attention.

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/blocks/blocks/trello.ts 5/5 Removed redundant success and error output properties from block outputs schema. Also corrected description text from "boards, cards, actions" to "lists, cards, actions".
apps/sim/tools/telegram/send_document.ts 5/5 Added defensive normalization to ensure files parameter is always an array when provided, fixing potential bug when single file object passed.
apps/sim/tools/trello/add_comment.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.
apps/sim/tools/trello/create_card.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.
apps/sim/tools/trello/get_actions.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.
apps/sim/tools/trello/list_cards.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.
apps/sim/tools/trello/list_lists.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.
apps/sim/tools/trello/update_card.ts 5/5 Removed redundant success and error output properties from schema; these are already part of the base ToolResponse interface.

Sequence Diagram

sequenceDiagram
    participant User
    participant TelegramTool as Telegram Send Document
    participant API as /api/tools/telegram/send-document

    User->>TelegramTool: files (single file or array)
    TelegramTool->>TelegramTool: Normalize files to array
    TelegramTool->>API: POST with normalizedFiles[]
    API-->>TelegramTool: Response
    TelegramTool-->>User: TelegramSendDocumentResponse
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit cd66fa8 into staging Dec 12, 2025
13 of 15 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/tools branch December 12, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants