-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(firecrawl): updated output for firecrawl extract #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryUpdated Firecrawl extract and search tool outputs to remove unused fields (
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Client
participant Tool as Firecrawl Tools
participant API as Firecrawl API
Note over Client,API: Extract Tool Flow
Client->>Tool: Call extract with URLs, prompt/schema
Tool->>API: POST /v2/extract
API-->>Tool: Returns jobId
Tool->>Tool: Start polling (5s intervals, 5min max)
loop Poll until complete/failed
Tool->>API: GET /v2/extract/{jobId}
API-->>Tool: Returns status & data
alt Status: completed
Tool-->>Client: Returns {success, jobId, data}
else Status: failed
Tool-->>Client: Returns error
end
end
Note over Client,API: Search Tool Flow
Client->>Tool: Call search with query
Tool->>API: POST /v2/search
API-->>Tool: Returns search results
Tool-->>Client: Returns {data}
Note over Client,API: Crawl Tool Flow
Client->>Tool: Call crawl with URL
Tool->>API: POST /v2/crawl
API-->>Tool: Returns jobId
Tool->>Tool: Start polling (5s intervals, 5min max)
loop Poll until complete/failed
Tool->>API: GET /v2/crawl/{jobId}
API-->>Tool: Returns status & pages
alt Status: completed
Tool-->>Client: Returns {pages, total, creditsUsed}
else Status: failed
Tool-->>Client: Returns error
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
-
apps/sim/tools/firecrawl/types.ts, line 196-207 (link)logic:
ExtractResponsetype includessourcesandwarningfields but they're removed from extract.ts outputs -
apps/sim/tools/firecrawl/types.ts, line 147-168 (link)logic:
SearchResponsetype includeswarningfield but it's removed from search.ts transformResponse
6 files reviewed, 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, no comments
Summary
Type of Change
Testing
Tested manually
Checklist