-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(teams): webhook notifications crash #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8f0ef58
31c34b2
842ef27
b7e814b
ebcd243
1d08796
8c32ad4
54cc937
774e5d5
e157ce5
3187493
6cd078b
929a352
12c4c2d
ebef5f3
c27c233
d480057
52edbea
b7bbef8
18b7032
b5da613
3fbd57c
e24f31c
f526c36
a0fb889
842200b
fcf52ac
25afacb
f9cfca9
837aabc
7052c76
088a086
9b1be0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,7 +109,7 @@ export default function Footer({ fullWidth = false }: FooterProps) { | |
| {FOOTER_BLOCKS.map((block) => ( | ||
| <Link | ||
| key={block} | ||
| href={`https://docs.sim.ai/blocks/${block.toLowerCase().replace(' ', '-')}`} | ||
| href={`https://docs.sim.ai/blocks/${block.toLowerCase().replaceAll(' ', '-')}`} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is this change fixing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @icecrasher321 Being Demonstrated:
|
||
| target='_blank' | ||
| rel='noopener noreferrer' | ||
| className='text-[14px] text-muted-foreground transition-colors hover:text-foreground' | ||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeLoopdroid you should be in packages/db not apps/sim?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Just to clarify, are you suggesting that the Teams webhook parsing logic should be moved into packages/db and then imported into apps/sim, or is the current fix in apps/sim acceptable for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was referring to you adding the comment in the readme -- for running bunx drizzle-kit migrate you should be inside packages/db
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, @icecrasher321
I’ve updated the README file to reflect the correct working directory for running migrations.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @waleedlatif1
Could you approve the pending workflow / Vercel auth when you have time?
Thanks