-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
ec5e2ce to
899978e
Compare
Greptile SummaryThis PR fixes OAuth providers (Wealthbox, Slack, Webflow) that were generating unstable reference IDs, which caused duplicate credential records in the database. Key Changes
Issues Found
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant App
participant OAuth Provider
participant Auth System
participant Database
User->>App: Connect OAuth service
App->>OAuth Provider: Initiate OAuth flow
OAuth Provider->>User: Request authorization
User->>OAuth Provider: Grant access
OAuth Provider->>Auth System: Return tokens & user data
Auth System->>Auth System: getUserInfo() extracts stable identifier
Note over Auth System: Wealthbox: 'wealthbox-user'<br/>Slack: '{teamId}-{userId}'<br/>Webflow: 'webflow-{userId}'
Auth System->>Database: Check existing (userId, providerId)
alt Existing credential found
Database->>Auth System: Return existing account
Auth System->>Database: Update accountId, tokens, scopes
Note over Database: Replace credential for same provider
else No existing credential
Auth System->>Database: Create new account record
Note over Database: Store with stable accountId
end
Database->>Auth System: Success
Auth System->>App: OAuth connected
App->>User: Show success message
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 3 comments
…eading to duplicate oauth records
899978e to
92c90f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
…eading to duplicate oauth records (#2441) * fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records * ack PR comments
…n, developer, and custom domain salesforce orgs (#2441) (#2444) * fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records (#2441) * fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records * ack PR comments * ack PR comments * cleanup salesforce refresh logic * ack more PR comments
Summary
Type of Change
Testing
Tested manually
Checklist