-
Notifications
You must be signed in to change notification settings - Fork 3.2k
improvement(wand): added more wands #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR enhances user experience by adding AI wand configurations to input fields across six integration blocks (Google Sheets, Microsoft Excel, SharePoint, Supabase, and Twilio Voice). The wands provide natural language assistance for generating complex inputs like spreadsheet ranges, JSON data structures, TwiML markup, and SQL expressions. SharePoint received the most extensive updates including template selection, column definitions, and list item fields. Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant UI as Block UI
participant Wand as AI Wand
participant API as Integration API
User->>UI: "Enter natural language description"
UI->>Wand: "Trigger wand with prompt template"
Wand->>Wand: "Generate formatted output"
Wand-->>UI: "Return structured data"
UI->>API: "Send formatted parameters"
API-->>User: "Execute operation"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
apps/sim/blocks/blocks/sharepoint.ts
Outdated
| id: 'pageContent', | ||
| title: 'Page Content', | ||
| title: 'Column Definitions', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field ID pageContent is misleading and incorrect for column definitions. This field is used for SharePoint list column definitions (as shown by the title "Column Definitions" and the wandConfig prompt), but the ID suggests it's for page content.
This will cause issues because:
- The field title says "Column Definitions" but the ID is
pageContent - Looking at line 478, the inputs definition shows
pageContentis described as "Page content" which doesn't match this usage - This creates confusion between page content (used in create_page operation) and column definitions (used in create_list operation)
| id: 'pageContent', | |
| title: 'Page Content', | |
| title: 'Column Definitions', | |
| id: 'columnDefinitions', | |
| title: 'Column Definitions', |
This change should also be reflected in the inputs section and any param processing logic.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/blocks/blocks/sharepoint.ts
Line: 168:169
Comment:
The field ID `pageContent` is misleading and incorrect for column definitions. This field is used for SharePoint list column definitions (as shown by the title "Column Definitions" and the wandConfig prompt), but the ID suggests it's for page content.
This will cause issues because:
1. The field title says "Column Definitions" but the ID is `pageContent`
2. Looking at line 478, the inputs definition shows `pageContent` is described as "Page content" which doesn't match this usage
3. This creates confusion between page content (used in create_page operation) and column definitions (used in create_list operation)
```suggestion
id: 'columnDefinitions',
title: 'Column Definitions',
```
This change should also be reflected in the inputs section and any param processing logic.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| id: 'columnDefinitions', | ||
| title: 'Column Definitions', | ||
| type: 'long-input', | ||
| placeholder: 'Provide page content', | ||
| placeholder: 'Optional: Define custom columns as JSON array', | ||
| condition: { field: 'operation', value: ['create_list'] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field is named columnDefinitions in the UI but gets mapped to pageContent in the transform function (line 471). This creates a disconnect between the field name users see and the actual parameter name sent to the API. Consider either:
- Keeping the field ID as
pageContentand updating just the title/placeholder to be more descriptive - Or update the SharePoint tool/API to accept
columnDefinitionsas the parameter name instead ofpageContent
This improves maintainability by keeping field IDs aligned with parameter names.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/blocks/blocks/sharepoint.ts
Line: 168:172
Comment:
The field is named `columnDefinitions` in the UI but gets mapped to `pageContent` in the transform function (line 471). This creates a disconnect between the field name users see and the actual parameter name sent to the API. Consider either:
1. Keeping the field ID as `pageContent` and updating just the title/placeholder to be more descriptive
2. Or update the SharePoint tool/API to accept `columnDefinitions` as the parameter name instead of `pageContent`
This improves maintainability by keeping field IDs aligned with parameter names.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Summary
Added more wand configs to unintuitive subblocks
Type of Change
Testing
Tested manually
Checklist