Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • removed deployment constraint for redeploying a2a workflows because it would show update irregardless of whether the underlying workflow had changes or not

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 13, 2026 9:19pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 13, 2026

Greptile Summary

Fixed the A2A workflow redeployment logic to properly check if the underlying workflow needs redeployment. Previously, handleUpdateAndRepublish only checked !isDeployed, which would show "update" regardless of whether the workflow actually changed. Now it also checks workflowNeedsRedeployment to accurately determine when redeployment is needed.

  • Modified the conditional in handleUpdateAndRepublish to check (!isDeployed || workflowNeedsRedeployment)
  • Added workflowNeedsRedeployment to the dependency array to ensure the callback updates when this value changes

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a focused bug fix that adds a missing condition check and dependency array entry. The logic is sound and consistent with the existing handlePublishNewAgent pattern (which only checks !isDeployed). The fix correctly addresses the issue described in the PR description, and the change is minimal with no side effects.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/a2a/a2a.tsx Fixed workflow redeployment logic by adding workflowNeedsRedeployment check to the condition and dependency array in handleUpdateAndRepublish

Sequence Diagram

sequenceDiagram
    participant User
    participant A2aDeploy
    participant onDeployWorkflow
    participant updateAgent
    participant publishAgent

    User->>A2aDeploy: Click "Update & Republish"
    A2aDeploy->>A2aDeploy: handleUpdateAndRepublish()
    
    alt !isDeployed OR workflowNeedsRedeployment
        A2aDeploy->>onDeployWorkflow: Deploy/Redeploy workflow
        onDeployWorkflow-->>A2aDeploy: Deployment complete
    end
    
    A2aDeploy->>updateAgent: Update agent metadata
    updateAgent-->>A2aDeploy: Agent updated
    
    A2aDeploy->>publishAgent: Publish agent
    publishAgent-->>A2aDeploy: Agent published
    A2aDeploy-->>User: Success
Loading

@waleedlatif1 waleedlatif1 merged commit 4be4203 into staging Jan 13, 2026
3 checks passed
waleedlatif1 added a commit that referenced this pull request Jan 13, 2026
…#2796)

* fix(a2a): removed deployment constraint for redeploying a2a workflows

* updated A2A tab copy state

* consolidated trigger types const
waleedlatif1 added a commit that referenced this pull request Jan 13, 2026
…#2796)

* fix(a2a): removed deployment constraint for redeploying a2a workflows

* updated A2A tab copy state

* consolidated trigger types const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants