fix(mcp): pass timeout to SDK callTool to override 60s default#3101
Merged
waleedlatif1 merged 1 commit intostagingfrom Feb 1, 2026
Merged
fix(mcp): pass timeout to SDK callTool to override 60s default#3101waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4f69d32 to
510dc3e
Compare
510dc3e to
fa918cc
Compare
Contributor
Greptile OverviewGreptile SummaryAdded timeout parameter to the MCP SDK's Key Changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Service as McpService
participant Client as McpClient
participant SDK as MCP SDK Client
participant Server as MCP Server
Note over Service: Config has timeout: 30000ms or custom
Service->>Client: createClient(config)
Note over Client: Stores config with timeout
Client->>SDK: new Client()
Service->>Client: callTool(toolCall)
Note over Client: Uses this.config.timeout || 600000
Client->>SDK: callTool(params, undefined, {timeout})
Note over SDK: Overrides 60s DEFAULT_REQUEST_TIMEOUT_MSEC
SDK->>Server: HTTP Request with configured timeout
Server-->>SDK: Tool result
SDK-->>Client: sdkResult
Client-->>Service: McpToolResult
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist