Skip to content

fix(function): disabled freestyle, VM by default with node-fetch#570

Merged
emir-karabeg merged 2 commits intostagingfrom
fix/function
Jun 28, 2025
Merged

fix(function): disabled freestyle, VM by default with node-fetch#570
emir-karabeg merged 2 commits intostagingfrom
fix/function

Conversation

@emir-karabeg
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Jun 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2025 2:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jun 28, 2025 2:34am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Major architectural change to function execution strategy, removing Freestyle sandbox in favor of VM-only execution with node-fetch support for network requests.

  • Completely removed Freestyle execution environment from apps/sim/app/api/function/execute/route.ts, simplifying architecture to VM-only
  • Added node-fetch support to VM context in apps/sim/app/api/function/execute/route.ts for handling network requests
  • Disabled multiple test suites in route.test.ts related to Freestyle execution and template variable edge cases
  • This change may impact compatibility with external npm packages previously supported through Freestyle

2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

@delve-auditor
Copy link

delve-auditor bot commented Jun 28, 2025

No security or compliance issues detected. Reviewed everything up to 9237948.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► route.ts
    Remove Freestyle execution, simplify to VM execution
► route.test.ts
    Skip tests related to Freestyle execution
► execute/route.ts
    Add input log to errors
► index.ts
    Optimize database operations
► socket-context.tsx
    Improve socket reconnection handling
Bug Fix ► workflow.tsx
    Fix workflow navigation
► workspace-header.tsx
    Fix workspace switching logic
Refactor ► operations.ts
    Simplify database operations
► permissions.ts
    Optimize workspace membership checks
► manager.ts
    Streamline room management logic

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@vercel vercel bot temporarily deployed to Preview – docs June 28, 2025 02:30 Inactive
@emir-karabeg emir-karabeg merged commit c43b039 into staging Jun 28, 2025
4 checks passed
@emir-karabeg emir-karabeg deleted the fix/function branch June 28, 2025 02:37
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…studioai#570)

* fix(function): disabled freestyle, VM by default with node-fetch

* fix: add input log to error

---------

Co-authored-by: Waleed Latif <walif6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants