Skip to content

feat: agent model dropdown combobox#572

Merged
waleedlatif1 merged 6 commits intostagingfrom
feat/agent-model-dropdown
Jun 28, 2025
Merged

feat: agent model dropdown combobox#572
waleedlatif1 merged 6 commits intostagingfrom
feat/agent-model-dropdown

Conversation

@emir-karabeg
Copy link
Collaborator

Description

Agent blocks can now accept variable inputs for models.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Pass in a variable that resolves to a model name in the model input.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jun 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2025 5:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jun 28, 2025 5:05pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced agent block functionality with variable model inputs through a new ComboBox component, replacing the standard dropdown for more flexible model selection.

  • Added new combobox SubBlockType in apps/sim/blocks/types.ts enabling searchable dropdown with text input
  • Implemented ComboBox component in apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/combobox.tsx with search, variable support, and accessibility features
  • Added error handling in apps/sim/serializer/index.ts for tool selection with fallback options
  • Modified temperature controls in apps/sim/blocks/blocks/agent.ts with model-specific ranges and improved validation

5 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile

@delve-auditor
Copy link

delve-auditor bot commented Jun 28, 2025

No security or compliance issues detected. Reviewed everything up to dee2d50.

Security Overview
  • 🔎 Scanned files: 17 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► document.tsx
    Update workspace URL paths
► document-loading.tsx
    Update knowledge base routing
► base.tsx
    Update knowledge routes for workspace context
► base-overview.tsx
    Add workspace context to knowledge base links
► combobox.tsx
    Add model dropdown with icons
► models.ts
    Add provider icons to model definitions
► utils.ts
    Add provider icon utility functions
► sub-block.tsx
    Add combobox support

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@vercel vercel bot temporarily deployed to Preview – docs June 28, 2025 17:00 Inactive
@waleedlatif1 waleedlatif1 merged commit ea4ad75 into staging Jun 28, 2025
4 checks passed
icecrasher321 added a commit that referenced this pull request Jun 28, 2025
* feat(agent): agent model dropdown combobox (#572)

* feat: agent model dropdown combobox

* fix(cli): package type for esm imports, missing realtime (#574)

* fix: package type for esm imports, missing realtime calls and use of migrate

* chore: bump cli

* fix sourceBlock null check

* fix(kb): fix kb navigation URLs

* fix(csp): update CSP to allow for google drive picker

* feat(dropdown): added optional icon to agent model dropdown

---------

Co-authored-by: Aditya Tripathi <aditya@climactic.co>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local>
Co-authored-by: Waleed Latif <walif6@gmail.com>

* fix concurrent req check (#576)

Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>

---------

Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Co-authored-by: Aditya Tripathi <aditya@climactic.co>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local>
Co-authored-by: Waleed Latif <walif6@gmail.com>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>
@emir-karabeg emir-karabeg deleted the feat/agent-model-dropdown branch June 29, 2025 02:09
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
* feat(agent): agent model dropdown combobox (simstudioai#572)

* feat: agent model dropdown combobox

* fix(cli): package type for esm imports, missing realtime (simstudioai#574)

* fix: package type for esm imports, missing realtime calls and use of migrate

* chore: bump cli

* fix sourceBlock null check

* fix(kb): fix kb navigation URLs

* fix(csp): update CSP to allow for google drive picker

* feat(dropdown): added optional icon to agent model dropdown

---------

Co-authored-by: Aditya Tripathi <aditya@climactic.co>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local>
Co-authored-by: Waleed Latif <walif6@gmail.com>

* fix concurrent req check (simstudioai#576)

Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>

---------

Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Co-authored-by: Aditya Tripathi <aditya@climactic.co>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local>
Co-authored-by: Waleed Latif <walif6@gmail.com>
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants