fix(autopan): migration missing by icecrasher321 · Pull Request #614 · simstudioai/sim

icecrasher321 · 2025-07-04T20:20:08Z

Description

Autopan column migration was missing. This PR adds it.
Upgrade es linter version to 2022 since it was breaking executor on each bun run lint.
Fix resulting type errors due to stricter reqs.

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (bun run test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

vercel · 2025-07-04T20:20:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 4, 2025 8:24pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 4, 2025 8:24pm

greptile-apps

PR Summary

Added missing migration for auto_pan feature and modernized several components with ES2022 features.

Added apps/sim/db/migrations/0050_big_mattie_franklin.sql to introduce auto_pan boolean column with default true in settings table
Updated TypeScript target to ES2022 in apps/sim/tsconfig.json enabling newer features like Object.hasOwn()
Modified apps/sim/executor/resolver.ts to expose accessibleBlocksMap property publicly
Added parallel execution support in apps/sim/app/api/__test-utils__/utils.ts with new sampleWorkflowState structure

_{7 files reviewed, 1 comment}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-04T20:20:39Z

apps/sim/executor/index.ts

        if (this.workflowInput && typeof this.workflowInput === 'object') {
          // Check if this is a chat workflow input (has both input and conversationId)
          if (
-            Object.prototype.hasOwnProperty.call(this.workflowInput, 'input') &&
-            Object.prototype.hasOwnProperty.call(this.workflowInput, 'conversationId')
+            Object.hasOwn(this.workflowInput, 'input') &&
+            Object.hasOwn(this.workflowInput, 'conversationId')
          ) {


style: This duplicate code block could be extracted into a helper function to avoid repetition of the property checking logic

delve-auditor · 2025-07-04T20:21:14Z

✅ No security or compliance issues detected. Reviewed everything up to 74d536a.

Security Overview

🔎 Scanned files: 7 changed file(s)

Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

* add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

* feat(logging): add additional logs for proxy routes * fix(blocks): workflow handler not working outside gui (#609) * fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter * fix(sidebar): added loop & parallel subblcoks to sidebar search * merged improvement/connection into staging (#604) * merged improvement/connection into staging * fix: merge conflicts and improved block path calculation * fix: removed migration * fix: removed duplicate call * fix: resolver and merge conflicts * fix: knowledge base folder * fix: settings modal * fix: typeform block * fix: parallel handler * fix: stores index * fix: tests * fix: tag-dropdown * improvement: start block input and tag dropdown * fix block id resolution + missing bracket * fix lint * fix test * works * fix * fix lint * Revert "fix lint" This reverts commit 433e2f9. --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> * fix(autopan): migration missing (#614) * add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Aditya Tripathi <aditya@climactic.co> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

* add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

* feat(logging): add additional logs for proxy routes * fix(blocks): workflow handler not working outside gui (simstudioai#609) * fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter * fix(sidebar): added loop & parallel subblcoks to sidebar search * merged improvement/connection into staging (simstudioai#604) * merged improvement/connection into staging * fix: merge conflicts and improved block path calculation * fix: removed migration * fix: removed duplicate call * fix: resolver and merge conflicts * fix: knowledge base folder * fix: settings modal * fix: typeform block * fix: parallel handler * fix: stores index * fix: tests * fix: tag-dropdown * improvement: start block input and tag dropdown * fix block id resolution + missing bracket * fix lint * fix test * works * fix * fix lint * Revert "fix lint" This reverts commit 433e2f9. --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> * fix(autopan): migration missing (simstudioai#614) * add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Aditya Tripathi <aditya@climactic.co> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

Vikhyath Mondreti added 4 commits July 4, 2025 13:06

add autopan migration

65a00c5

fix lint

5edf992

fix linter

b60abe8

fix tests

74d536a

greptile-apps bot reviewed Jul 4, 2025

View reviewed changes

vercel bot deployed to Preview – sim July 4, 2025 20:24 View deployment

icecrasher321 merged commit 8b4e330 into staging Jul 4, 2025
6 checks passed

icecrasher321 added a commit that referenced this pull request Jul 4, 2025

fix(autopan): migration missing (#614)

01eedb3

* add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

icecrasher321 mentioned this pull request Jul 4, 2025

v0.2.7: fix + feat #615

Merged

13 tasks

waleedlatif1 pushed a commit that referenced this pull request Jul 7, 2025

fix(autopan): migration missing (#614)

f485fd6

* add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

waleedlatif1 pushed a commit that referenced this pull request Jul 7, 2025

fix(autopan): migration missing (#614)

10f7500

* add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

waleedlatif1 deleted the fix/autopan-migration branch July 8, 2025 23:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(autopan): migration missing#614

fix(autopan): migration missing#614
icecrasher321 merged 4 commits intostagingfrom
fix/autopan-migration

icecrasher321 commented Jul 4, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jul 4, 2025

Uh oh!

delve-auditor bot commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

icecrasher321 commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Security Considerations:

Uh oh!

vercel bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

delve-auditor bot commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

icecrasher321 commented Jul 4, 2025 •

edited

Loading

vercel bot commented Jul 4, 2025 •

edited

Loading