v0.3.2: improvement + fix + feat #708

waleedlatif1 · 2025-07-16T22:01:30Z

feat(sidebar): sidebar toggle and search (feat(sidebar): sidebar toggle and search #700)
fix(schedule): fix for custom cron (fix(schedule): fix for custom cron #699)
fix(sockets): delete block case (fix(sockets): delete block edge case #703)
fix(invitation): allow admins to remove members from workspace (fix(invitation): allow admins to remove members from workspace #701)
improvement(voice): interrupt UI + mute mic while agent is talking (improvement(voice): interrupt UI + mute mic while agent is talking #705)
fix: permissions check for duplicating workflow (fix: permissions check for duplicating workflow #706)
fix(subflow): fixed subflow execution regardless of path decision (fix(subflow): fixed subflow execution regardless of path decision #707)

* fix: sidebar toggle * feat: search complete

* fix: added cronExpression field and fixed formatting * fix: modified the test.ts file #699 * added additional validation --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com>

* fix(invitation): added ability for admins to remove members of their workspace * lint * remove references to workspace_member db table * remove deprecated @next/font * only allow admin to rename workspace * bring workflow name change inline, remove dialog

) * improvement(voice): interrupt UI + live transcription * cleanup logs * remove cross

* fix typo in docs file * fix(subflows): fixed subflows executing irrespective of active path * added routing strategy * reorganized executor * brought folder renaming inline * cleanup

vercel · 2025-07-16T22:01:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim (staging)	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 10:01pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 16, 2025 10:01pm

delve-auditor · 2025-07-16T22:02:44Z

✅ No security or compliance issues detected. Reviewed everything up to 92fe353.

Security Overview

🔎 Scanned files: 80 changed file(s)

Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

greptile-apps

Greptile Summary

This PR (v0.3.2) introduces several major improvements and critical fixes across the codebase:

Path-Aware Execution System: A significant architectural improvement that fixes subflow execution by ensuring blocks only execute when explicitly selected by router/condition blocks. This includes:
- New PathTracker integration for loop and parallel handlers
- Block categorization into routing, flow control, and regular blocks
- Comprehensive test coverage for nested routing scenarios
Code Organization & Type Safety:
- Migration from relative imports to path aliases using '@/executor/*' pattern
- Introduction of BlockType enum replacing string literals for block types
- Improved folder structure with dedicated directories for core components
Feature Improvements:
- Sidebar toggle and global search (Cmd+K shortcut)
- Voice interface interruption capability and audio sync
- Custom cron expression validation
- Enhanced workspace member management for admins
Permission System Overhaul:
- Consolidated access control using permissions table
- Removed redundant workspaceMember table
- Improved invitation system with better email matching

Confidence score: 4 /5

This PR is generally safe to merge with careful testing of workflow execution paths
While the changes are extensive, they are well-tested and improve system reliability. The lower score is due to the significant changes to core execution logic
Key files needing attention:
- apps/sim/executor/index.ts (core execution logic changes)
- apps/sim/executor/routing/routing.ts (new path tracking system)
- apps/sim/app/api/workspaces/* (permission system changes)

_{78 files reviewed, 16 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-16T22:02:04Z

apps/sim/app/api/workspaces/invitations/[id]/route.test.ts

+    const mockQuery = {
+      from: vi.fn().mockReturnThis(),
+      where: vi.fn().mockReturnThis(),
+      then: vi.fn((callback: (rows: any[]) => any) => {


style: consider adding type definition for callback parameter instead of using any[]

greptile-apps · 2025-07-16T22:02:04Z

apps/sim/lib/schedules/utils.ts

+  const cronExpression = getSubBlockValue(starterBlock, 'cronExpression') || null
+
+  // Validate cron expression if provided
+  if (cronExpression) {
+    const validation = validateCronExpression(cronExpression)
+    if (!validation.isValid) {
+      throw new Error(`Invalid cron expression: ${validation.error}`)
+    }
+  }


style: Consider moving validation logic into its own function to keep getScheduleTimeValues more focused on value extraction

greptile-apps · 2025-07-16T22:02:04Z

apps/sim/app/api/organizations/invitations/accept/route.ts

          wsInvitation.expiresAt &&
          new Date().toISOString() <= wsInvitation.expiresAt.toISOString()
        ) {


style: same date comparison issue here - use native Date objects instead of string conversion

Suggested change

wsInvitation.expiresAt &&

new Date().toISOString() <= wsInvitation.expiresAt.toISOString()

) {

wsInvitation.expiresAt &&

new Date() <= wsInvitation.expiresAt

) {

greptile-apps · 2025-07-16T22:02:05Z

apps/sim/app/workspace/[workspaceId]/templates/templates.tsx

      stars={template.stars}
      icon={template.icon}
      iconColor={template.color}
      state={template.state as { blocks?: Record<string, { type: string; name?: string }> }}


style: type assertion to Record<string, { type: string; name?: string }> might be unsafe. Consider defining a proper type

greptile-apps · 2025-07-16T22:02:06Z

apps/sim/app/api/organizations/[id]/workspaces/route.ts

          isOwner: eq(workspace.ownerId, memberId),
          permissionType: permissions.permissionType,
-          joinedAt: workspaceMember.joinedAt,
+          createdAt: permissions.createdAt,


style: Consider adding an explicit alias for permissions.createdAt since it's used as both joinedAt and createdAt in the response

greptile-apps · 2025-07-16T22:02:12Z

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx

+  const fetchTemplates = useCallback(async () => {
+    setIsTemplatesLoading(true)
+    try {
+      // Fetch templates from API, ordered by views (most popular first)
+      const response = await fetch('/api/templates?limit=8&offset=0')
+
+      if (!response.ok) {
+        throw new Error(`Failed to fetch templates: ${response.status}`)
+      }
+
+      const apiResponse = await response.json()
+
+      // Map API response to TemplateData format
+      const fetchedTemplates: TemplateData[] =
+        apiResponse.data?.map((template: any) => ({
+          id: template.id,
+          title: template.name,
+          description: template.description || '',
+          author: template.author,
+          usageCount: formatUsageCount(template.views || 0),
+          stars: template.stars || 0,
+          icon: template.icon || 'FileText',
+          iconColor: template.color || '#6B7280',
+          state: template.state,
+          isStarred: template.isStarred || false,
+        })) || []
+
+      setTemplates(fetchedTemplates)
+      logger.info(`Templates loaded successfully: ${fetchedTemplates.length} templates`)
+    } catch (error) {
+      logger.error('Error fetching templates:', error)
+      // Set empty array on error
+      setTemplates([])
+    } finally {
+      setIsTemplatesLoading(false)
+    }
+  }, [])


logic: Consider using a type-safe API response interface instead of 'any' for template mapping

greptile-apps · 2025-07-16T22:02:17Z

apps/sim/executor/tests/executor-layer-validation.test.ts

+  it('should test the full executor flow and see what happens', async () => {
+    // Mock the necessary functions to avoid actual API calls
+    const mockInput = {}
+
+    try {
+      // Execute the workflow
+      const result = await executor.execute('test-workflow-id')
+
+      // Check if it's an ExecutionResult (not StreamingExecution)
+      if ('success' in result) {
+        // Check if there are any logs that might indicate what happened
+        if (result.logs) {
+        }
+
+        // The test itself doesn't need to assert anything specific
+        // We just want to see what the executor does
+        expect(result.success).toBeDefined()
+      } else {
+        expect(result).toBeDefined()
+      }
+    } catch (error) {
+      console.error('Execution error:', error)
+      // Log the error but don't fail the test - we want to see what happens
+    }
+  })


style: First test is incomplete - empty if block and no specific assertions. Either add meaningful assertions or remove test.

greptile-apps · 2025-07-16T22:02:18Z

apps/sim/executor/tests/executor-layer-validation.test.ts

+    // Create a mock context in the exact state after the condition executes
+    const context = (executor as any).createExecutionContext('test-workflow', new Date())


style: Using 'as any' to access private method createExecutionContext. Consider making method protected or adding test utilities.

greptile-apps · 2025-07-16T22:02:20Z

apps/sim/executor/routing/routing.ts

+    const flowControlHandles = [
+      'parallel-start-source',
+      'parallel-end-source',
+      'loop-start-source',
+      'loop-end-source',
+    ]


style: Consider moving flowControlHandles to a constant or configuration object for better maintainability

greptile-apps · 2025-07-16T22:02:24Z

apps/sim/executor/handlers/parallel/parallel-handler.ts

+          } catch (error) {
+            logger.warn(`PathTracker check failed for ${blockType} block ${block.id}:`, error)
+            // Default to true to maintain existing behavior if PathTracker fails
+            isInActivePath = true
+          }


logic: Default to true in error case could mask issues. Consider adding error details to logs

emir-karabeg and others added 7 commits July 15, 2025 20:41

feat(sidebar): sidebar toggle and search (#700)

b13f339

* fix: sidebar toggle * feat: search complete

fix(schedule): fix for custom cron (#699)

19ca9c7

* fix: added cronExpression field and fixed formatting * fix: modified the test.ts file #699 * added additional validation --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com>

fix(sockets): delete block case (#703)

27c248a

improvement(voice): interrupt UI + mute mic while agent is talking (#705

55a9adf

) * improvement(voice): interrupt UI + live transcription * cleanup logs * remove cross

fix: permissions check for duplicating workflow (#706)

4c6c727

fix(subflow): fixed subflow execution regardless of path decision (#707)

92fe353

* fix typo in docs file * fix(subflows): fixed subflows executing irrespective of active path * added routing strategy * reorganized executor * brought folder renaming inline * cleanup

greptile-apps bot reviewed Jul 16, 2025

View reviewed changes

waleedlatif1 merged commit 8f71684 into main Jul 16, 2025
9 checks passed

		// Create a mock context in the exact state after the condition executes
		const context = (executor as any).createExecutionContext('test-workflow', new Date())

v0.3.2: improvement + fix + feat #708

v0.3.2: improvement + fix + feat #708

Uh oh!

Conversation

waleedlatif1 commented Jul 16, 2025

Uh oh!

vercel bot commented Jul 16, 2025

Uh oh!

delve-auditor bot commented Jul 16, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Summary

Confidence score: 4 /5

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants