-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(oauth): added advanced mode for all tools with oauth and selectors #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR introduces a significant architectural improvement by adding an advanced mode for OAuth-enabled tools and selectors across the codebase. The key changes are:
- Added support for manual parameter input alongside UI selectors, enabling async execution scenarios
- Moved parameter validation from block-level to tool-level for better encapsulation
- Standardized import paths using @/ aliases instead of relative paths
- Consolidated response types into unified type definitions
However, there are critical issues that need to be addressed:
-
Duplicate interface definitions in multiple files:
- perplexity/types.ts: PerplexityChatResponse
- google/types.ts: GoogleSearchResponse
- stagehand/types.ts: StagehandAgentResponse
These duplications will cause TypeScript compilation errors and need to be fixed.
-
Potentially redundant interfaces in supabase/types.ts and elevenlabs/types.ts that could lead to confusion about which interface to use.
Confidence score: 2/5
- This PR requires fixes before merging due to interface duplication issues.
- While the architectural changes are good, the duplicate interfaces will cause immediate compilation errors if merged.
- Files that need attention:
- apps/sim/tools/perplexity/types.ts
- apps/sim/tools/google/types.ts
- apps/sim/tools/stagehand/types.ts
- apps/sim/tools/supabase/types.ts
- apps/sim/tools/elevenlabs/types.ts
94 files reviewed, 19 comments
Edit PR Review Bot Settings | Greptile
|
✅ No security or compliance issues detected. Reviewed everything up to cc3246d. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
…selectors (#721) * fixed SVG error, added tool-level awareness for param validation * added advanced mode for oauth block * added wealthbox advanced mode * fixed wealthbox * moved types to types file * ack pr comments
…selectors (simstudioai#721) * fixed SVG error, added tool-level awareness for param validation * added advanced mode for oauth block * added wealthbox advanced mode * fixed wealthbox * moved types to types file * ack pr comments
Description
Type of change
How Has This Been Tested?
Tested manually to ensure that we could execute by manually providing the params as well as using the selectors.
Checklist:
bun run test)Security Considerations: