Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Description

  • Added advanced mode for all tools with oauth and selectors. This makes it so that users can also pass in params as input variables and use that for async executions. In the UI, the selectors are still there to help users but this enables a lot of async usecases for when the workflow is deployed.
  • Also, the validation for params that are required is now at the tool-level, instead of at the block level.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually to ensure that we could execute by manually providing the params as well as using the selectors.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 5:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 18, 2025 5:37pm

@waleedlatif1 waleedlatif1 changed the title improvement(oatuh): added advanced mode for all tools with oauth and selectors improvement(oauth): added advanced mode for all tools with oauth and selectors Jul 18, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR introduces a significant architectural improvement by adding an advanced mode for OAuth-enabled tools and selectors across the codebase. The key changes are:

  1. Added support for manual parameter input alongside UI selectors, enabling async execution scenarios
  2. Moved parameter validation from block-level to tool-level for better encapsulation
  3. Standardized import paths using @/ aliases instead of relative paths
  4. Consolidated response types into unified type definitions

However, there are critical issues that need to be addressed:

  1. Duplicate interface definitions in multiple files:

    • perplexity/types.ts: PerplexityChatResponse
    • google/types.ts: GoogleSearchResponse
    • stagehand/types.ts: StagehandAgentResponse
      These duplications will cause TypeScript compilation errors and need to be fixed.
  2. Potentially redundant interfaces in supabase/types.ts and elevenlabs/types.ts that could lead to confusion about which interface to use.

Confidence score: 2/5

  1. This PR requires fixes before merging due to interface duplication issues.
  2. While the architectural changes are good, the duplicate interfaces will cause immediate compilation errors if merged.
  3. Files that need attention:
    • apps/sim/tools/perplexity/types.ts
    • apps/sim/tools/google/types.ts
    • apps/sim/tools/stagehand/types.ts
    • apps/sim/tools/supabase/types.ts
    • apps/sim/tools/elevenlabs/types.ts

94 files reviewed, 19 comments
Edit PR Review Bot Settings | Greptile

@delve-auditor
Copy link

delve-auditor bot commented Jul 18, 2025

No security or compliance issues detected. Reviewed everything up to cc3246d.

Security Overview
  • 🔎 Scanned files: 92 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@vercel vercel bot temporarily deployed to Preview – docs July 18, 2025 17:33 Inactive
@waleedlatif1 waleedlatif1 merged commit 732df04 into staging Jul 18, 2025
6 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/oauth-blocks branch July 18, 2025 17:53
waleedlatif1 added a commit that referenced this pull request Jul 18, 2025
…selectors (#721)

* fixed SVG error, added tool-level awareness for param validation

* added advanced mode for oauth block

* added wealthbox advanced mode

* fixed wealthbox

* moved types to types file

* ack pr comments
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…selectors (simstudioai#721)

* fixed SVG error, added tool-level awareness for param validation

* added advanced mode for oauth block

* added wealthbox advanced mode

* fixed wealthbox

* moved types to types file

* ack pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants