Skip to content

improvement(kb): add loading logic for document selector for kb block #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jul 18, 2025
Merged

improvement(kb): add loading logic for document selector for kb block #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...ts/workflow-block/components/sub-block/components/document-selector/document-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use client'

import { useCallback, useEffect, useState } from 'react'
import { Check, ChevronDown, FileText } from 'lucide-react'
import { Check, ChevronDown, FileText, RefreshCw } from 'lucide-react'
import { Button } from '@/components/ui/button'
import {
Command,
Expand Down Expand Up @@ -54,6 +54,7 @@ export function DocumentSelector({
const [error, setError] = useState<string | null>(null)
const [open, setOpen] = useState(false)
const [selectedDocument, setSelectedDocument] = useState<DocumentData | null>(null)
const [loading, setLoading] = useState(false)

// Use the proper hook to get the current value and setter
const [storeValue, setStoreValue] = useSubBlockValue(blockId, subBlock.id)
Expand All @@ -72,6 +73,7 @@ export function DocumentSelector({
return
}

setLoading(true)
setError(null)

try {
Expand All @@ -93,6 +95,8 @@ export function DocumentSelector({
if ((err as Error).name === 'AbortError') return
setError((err as Error).message)
setDocuments([])
} finally {
setLoading(false)
}
}, [knowledgeBaseId])

Expand Down Expand Up @@ -192,7 +196,12 @@ export function DocumentSelector({
<CommandInput placeholder='Search documents...' />
<CommandList>
<CommandEmpty>
{error ? (
{loading ? (
<div className='flex items-center justify-center p-4'>
<RefreshCw className='h-4 w-4 animate-spin' />
<span className='ml-2'>Loading documents...</span>
</div>
) : error ? (
<div className='p-4 text-center'>
<p className='text-destructive text-sm'>{error}</p>
</div>
Expand Down