-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(webhook-triggers): multiple webhook trigger blocks #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 3533255. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR introduces a significant architectural change in how webhook triggers are handled within workflows. The key changes include:
- Moving webhook configuration from workflow-level to block-level through a new
WebhookTriggerBlock - Adding a
block_idcolumn to the webhook table to support multiple webhook triggers per workflow - Updating the executor to support starting workflows from webhook trigger blocks
- Modifying the API and UI components to handle block-level webhook configuration
The change enables multiple webhook triggers within a single workflow, similar to starter blocks but specifically for webhooks. This improves modularity and provides more flexibility in workflow design.
PR Description Notes:
- The test section only includes a video link without written test scenarios
- The tests checkbox is unchecked in the checklist
Confidence score: 3/5
- This PR is moderately safe to merge but requires careful testing of webhook execution paths
- The score reflects concerns about missing test coverage and potential edge cases in webhook execution
- Files needing attention:
- apps/sim/lib/webhooks/utils.ts: Webhook execution logic needs thorough testing
- apps/sim/blocks/blocks/webhook-trigger.ts: Implementation seems basic and may need additional validation
- apps/sim/app/api/webhooks/route.ts: Edge cases in backwards compatibility need verification
14 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile
...w/[workflowId]/components/workflow-block/components/sub-block/components/webhook/webhook.tsx
Show resolved
Hide resolved
.../sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx
Show resolved
Hide resolved
| { | ||
| "title": "Blocks", | ||
| "pages": [ | ||
| "agent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making this alphabetical order
…l, added chat fields into tag dropdown for start block
…block, removed unique constraint on scheule workflows and added combo constraint on workflowid/blockid and schedule
) * checkpoint * correctly clear status * works * improvements * fix build issue * add docs * remove comments, logs * fix migration to have foreign ref key * change filename to snake case * modified dropdown to match combobox styling * added block type for triggers, split out schedule block into a separate trigger * added chat trigger to start block, removed startAt from schedule modal, added chat fields into tag dropdown for start block * removed startedAt for schedules, separated schedules into a separate block, removed unique constraint on scheule workflows and added combo constraint on workflowid/blockid and schedule * icons fix --------- Co-authored-by: Waleed Latif <walif6@gmail.com>
Description
Webhook Trigger Block --> Can configure triggers to workflows. Don't take input -- similar to start blocks, but just for webhooks. Support the same providers and other functionality as start block webhook functionality.
Makes webhook have block level identification since it's not a global property of the workflow anymore.
Added docs for the block
Type of change
How Has This Been Tested?
Screen.Recording.2025-07-19.at.11.38.09.AM.mov
Checklist:
bun run test)Security Considerations: