Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Description

Fixed docker container healthchecks, added instructions to README for pgvector

Fixes #720, #658

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Tested manually to ensure the realtime server works now with healthchecks in place.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Jul 21, 2025 4:23am
sim 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 4:23am

@delve-auditor
Copy link

delve-auditor bot commented Jul 21, 2025

No security or compliance issues detected. Reviewed everything up to af7eef8.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Documentation ► README.md
    Add pgvector extension setup instructions and requirements
Configuration changes ► docker-compose.local.yml
    Update healthcheck endpoint
► docker-compose.prod.yml
    Update healthcheck endpoint

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR addresses two key operational issues in the SimStudio infrastructure:

  1. Fixes Docker container healthchecks by updating the realtime service's healthcheck endpoint from '/' to '/health'
  2. Enhances documentation with clear pgvector setup requirements in the README

The changes modify the Docker Compose configurations (both production and local) to use the correct healthcheck endpoint, preventing startup failures. The README has been updated with comprehensive instructions for setting up PostgreSQL with the required pgvector extension, which is essential for AI features like knowledge bases and semantic search.

Confidence score: 4/5

  1. This PR is safe to merge as it fixes critical infrastructure issues without introducing breaking changes
  2. The score reflects high confidence in the changes due to their straightforward nature and clear documentation, with a point deducted due to lack of automated tests
  3. Files needing attention:
    • Verify that '/health' endpoint is properly implemented in the realtime service
    • Double-check the pgvector version compatibility in README against the current deployment requirements

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 8007601 into staging Jul 21, 2025
5 of 6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/dock branch July 22, 2025 19:57
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…to README for pgvector (simstudioai#735)

* fixed docker container healthchecks

* add additional instructions for pgvector extension to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants