Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Description

Fixed condition block dropdown not showing in conditions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

Additional Information:

Screenshot 2025-07-21 at 10 40 29 AM

@vercel
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:41pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 21, 2025 5:41pm

@delve-auditor
Copy link

delve-auditor bot commented Jul 21, 2025

No security or compliance issues detected. Reviewed everything up to 9dac658.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► condition-input.tsx
    Fixed condition block dropdown functionality
    Improved editor value handling and trigger checks

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR simplifies and fixes the condition block dropdown functionality in the workflow editor. The key changes include:

  • Removed the standalone updateBlockValue function and integrated its logic directly into the Editor component's onValueChange handler
  • Improved state management for showing/hiding tag and environment variable dropdowns
  • Streamlined the data flow by handling cursor position and dropdown triggers in a single place

This change addresses a bug where condition block dropdowns weren't appearing correctly, making the feature more reliable and the code more maintainable.

Confidence score: 4/5

  1. This PR is safe to merge as it's a focused bug fix with minimal impact on other features
  2. The code changes are straightforward and improve the organization while fixing the dropdown functionality
  3. The condition-input.tsx file needs careful attention to ensure the dropdown behavior works as expected

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit d94bfd9 into staging Jul 21, 2025
6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/code-variables branch July 21, 2025 18:19
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants