-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(router): fixed routing issue with workflow block, added tests #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 576a44d. Security Overview
Detected Code Changes
Reply to this PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes a critical routing issue in the workflow execution engine where workflow blocks would incorrectly execute even when not selected by router blocks. The core changes include:
- Recategorizing WORKFLOW blocks as FLOW_CONTROL instead of REGULAR_BLOCK to ensure proper routing awareness
- Fixing dependency checking logic to properly handle unselected paths
- Adding comprehensive test coverage for multi-input routing and workflow execution scenarios
The changes affect the executor's core routing system, particularly in how it handles path selection and dependencies. When a router or condition block makes a selection, blocks on unselected paths are now correctly prevented from executing, fixing the workflow routing behavior shown in the PR screenshots.
Confidence score: 5/5
- This PR is very safe to merge - it fixes a clear bug with solid test coverage
- The changes are well-tested with both unit tests and manual verification, and the fixes are focused on correcting specific incorrect behaviors rather than introducing new patterns
- Key files needing attention:
- apps/sim/executor/index.ts (core dependency logic changes)
- apps/sim/executor/routing/routing.ts (block categorization)
- apps/sim/executor/tests/multi-input-routing.test.ts (new test coverage)
7 files reviewed, 2 comments
…mstudioai#739) * fixed routing issue with workflow block, added tests * add new dmeo * change console to logger * new demo * changed all console to logger
Description
Fixed routing issue with workflow block, added tests
Type of change
How Has This Been Tested?
Tested manually & added executor tests & additional documentation.
Checklist:
bun run test)Security Considerations:
Additional Information:
Workflow doesn't execute when not chosen by the router:

Does execute when chosen:
