-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(webhooks): ms teams webhook #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 066211a. Security Overview
Detected Code Changes
Reply to this PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR adds Microsoft Teams webhook integration to the platform's webhook system. The implementation includes:
- A new
MicrosoftTeamsConfigcomponent and interface for handling Teams-specific webhook configuration - HMAC secret management for secure webhook authentication
- Integration with the existing webhook modal and trigger endpoints
- Teams-specific message formatting and validation logic
- Proper icon and provider registration in the webhook block system
The changes follow the established patterns used for other webhook providers (like Slack and Discord) while implementing Teams-specific requirements such as HMAC authentication and timing constraints.
Confidence score: 4/5
- This PR is generally safe to merge as it follows established patterns and includes security measures
- The high score reflects thorough implementation across all required components, proper security handling, and comprehensive testing evidence
- Areas needing attention:
- apps/sim/app/api/webhooks/trigger/[path]/route.ts: Review HMAC validation logic
- apps/sim/lib/webhooks/utils.ts: Verify message formatting for Teams-specific requirements
7 files reviewed, 4 comments
| testResult: { | ||
| success: boolean | ||
| message?: string | ||
| test?: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: test prop has type 'any'. Consider defining a specific type for test results
Description
MS Teams Webhook with secret configuration.
Type of change
How Has This Been Tested?
Screen.Recording.2025-07-21.at.12.00.43.PM.mov
Checklist:
bun run test)Security Considerations: