Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Description

MS Teams Webhook with secret configuration.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screen.Recording.2025-07-21.at.12.00.43.PM.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 7:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 21, 2025 7:02pm

@delve-auditor
Copy link

delve-auditor bot commented Jul 21, 2025

No security or compliance issues detected. Reviewed everything up to 066211a.

Security Overview
  • 🔎 Scanned files: 7 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► route.ts (webhooks/test)
    Add Microsoft Teams webhook test logic
► route.ts (webhooks/trigger)
    Implement Microsoft Teams webhook handling
► microsoftteams.tsx
    Add Microsoft Teams configuration UI
► webhook-modal.tsx
    Add Microsoft Teams provider support
► webhook.tsx
    Add Microsoft Teams webhook provider
► webhook.ts
    Add Microsoft Teams block configuration
► utils.ts
    Add Microsoft Teams webhook utilities

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds Microsoft Teams webhook integration to the platform's webhook system. The implementation includes:

  • A new MicrosoftTeamsConfig component and interface for handling Teams-specific webhook configuration
  • HMAC secret management for secure webhook authentication
  • Integration with the existing webhook modal and trigger endpoints
  • Teams-specific message formatting and validation logic
  • Proper icon and provider registration in the webhook block system

The changes follow the established patterns used for other webhook providers (like Slack and Discord) while implementing Teams-specific requirements such as HMAC authentication and timing constraints.

Confidence score: 4/5

  1. This PR is generally safe to merge as it follows established patterns and includes security measures
  2. The high score reflects thorough implementation across all required components, proper security handling, and comprehensive testing evidence
  3. Areas needing attention:
    • apps/sim/app/api/webhooks/trigger/[path]/route.ts: Review HMAC validation logic
    • apps/sim/lib/webhooks/utils.ts: Verify message formatting for Teams-specific requirements

7 files reviewed, 4 comments

Edit Code Review Bot Settings | Greptile

testResult: {
success: boolean
message?: string
test?: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: test prop has type 'any'. Consider defining a specific type for test results

@icecrasher321 icecrasher321 merged commit 7739917 into staging Jul 21, 2025
6 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/teams-webhook branch July 22, 2025 19:58
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants