-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(webhook): immediate acks from webhooks #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR modifies the webhook processing logic in apps/sim/lib/webhooks/utils.ts to make webhook acknowledgments immediate rather than waiting for workflow execution to complete. The key change is removing the await statement before executeWorkflowFromPayload, allowing the system to respond to webhook requests immediately while processing workflows asynchronously in the background.
This change was specifically implemented to address timeout issues with Microsoft Teams webhooks, which require quick responses. The modification includes proper error handling for asynchronous execution failures through a .catch() block that logs any errors that occur after the initial response has been sent.
Confidence score: 4/5
- This PR is safe to merge as it improves webhook reliability without breaking existing functionality
- The high confidence score is due to the straightforward nature of the change and the addition of proper error handling
- Particular attention should be paid to
apps/sim/lib/webhooks/utils.tsto ensure no webhook processing logic is broken by this change
1 file reviewed, no comments
|
✅ No security or compliance issues detected. Reviewed everything up to 45da9dc. Security Overview
Detected Code Changes
Reply to this PR with |
* fix(webhook): immediate acks from webhooks for teams * change default message
Description
Remove await before executing webhooks -- so acks are sent immediately back.
Type of change
How Has This Been Tested?
Screen.Recording.2025-07-21.at.8.16.32.PM.mov
Checklist:
bun run test)Security Considerations: