Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Description

Local linter issues with kebab case styling. E.g. fill-rule --> fillRule

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 8:11pm
sim 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 8:11pm

@waleedlatif1 waleedlatif1 merged commit d8a7aaa into staging Jul 22, 2025
2 of 5 checks passed
@delve-auditor
Copy link

delve-auditor bot commented Jul 22, 2025

No security or compliance issues detected. Reviewed everything up to dec1ab8.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes React/JSX linting issues by converting kebab-case SVG attributes to camelCase in the Qdrant icon component across three files. The changes standardize SVG attribute naming to comply with React's JSX requirements, where DOM properties must use camelCase instead of the kebab-case format used in standard HTML/SVG.

The specific conversions made include:

  • clip-pathclipPath
  • clip-ruleclipRule
  • fill-rulefillRule
  • stop-colorstopColor
  • stop-opacitystopOpacity

These changes affect the Qdrant icon in three locations: the main icons component file (apps/sim/components/icons.tsx), the documentation file (apps/docs/content/docs/tools/qdrant.mdx), and the landing page integrations section (apps/sim/app/(landing)/components/sections/integrations.tsx). This is a common requirement when embedding SVG markup directly in React components, as JSX parsers expect camelCase property names that correspond to JavaScript DOM element properties rather than HTML attribute names.

Confidence score: 5/5

  • This is an extremely safe change that only fixes JSX syntax compliance without affecting functionality
  • The conversions are standard React/JSX attribute transformations that are well-established and necessary
  • No files need additional attention as these are purely syntactic fixes

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@waleedlatif1 waleedlatif1 deleted the fix/qdrant-styling branch July 27, 2025 01:34
@waleedlatif1 waleedlatif1 restored the fix/qdrant-styling branch July 27, 2025 01:34
@waleedlatif1 waleedlatif1 deleted the fix/qdrant-styling branch July 27, 2025 01:34
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants