Skip to content

fix(condition): fix bug where user can't edit if container when else if is added #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jul 23, 2025
Merged

fix(condition): fix bug where user can't edit if container when else if is added #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions ...workflowId]/components/workflow-block/components/sub-block/components/condition-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function ConditionInput({
disabled = false,
}: ConditionInputProps) {
const [storeValue, setStoreValue] = useSubBlockValue(blockId, subBlockId)
const editorRef = useRef<HTMLDivElement>(null)
const containerRef = useRef<HTMLDivElement>(null)
const [visualLineHeights, setVisualLineHeights] = useState<{
[key: string]: number[]
}>({})
Expand Down Expand Up @@ -233,10 +233,10 @@ export function ConditionInput({

// Update the line counting logic to be block-specific
useEffect(() => {
if (!editorRef.current || conditionalBlocks.length === 0) return
if (!containerRef.current || conditionalBlocks.length === 0) return

const calculateVisualLines = () => {
const preElement = editorRef.current?.querySelector('pre')
const preElement = containerRef.current?.querySelector('pre')
if (!preElement) return

const newVisualLineHeights: { [key: string]: number[] } = {}
Expand Down Expand Up @@ -296,7 +296,7 @@ export function ConditionInput({
calculateVisualLines()

const resizeObserver = new ResizeObserver(calculateVisualLines)
resizeObserver.observe(editorRef.current)
resizeObserver.observe(containerRef.current)

return () => resizeObserver.disconnect()
}, [conditionalBlocks])
Expand Down Expand Up @@ -332,7 +332,7 @@ export function ConditionInput({
const data = JSON.parse(e.dataTransfer.getData('application/json'))
if (data.type !== 'connectionBlock') return

const textarea: any = editorRef.current?.querySelector(
const textarea: any = containerRef.current?.querySelector(
`[data-block-id="${blockId}"] textarea`
)
const dropPosition = textarea?.selectionStart ?? 0
Expand Down Expand Up @@ -434,7 +434,7 @@ export function ConditionInput({

// Focus the new block's editor after a short delay
setTimeout(() => {
const textarea: any = editorRef.current?.querySelector(
const textarea: any = containerRef.current?.querySelector(
`[data-block-id="${newBlock.id}"] textarea`
)
if (textarea) {
Expand Down Expand Up @@ -479,7 +479,7 @@ export function ConditionInput({
// Add useEffect to handle keyboard events for both dropdowns
useEffect(() => {
conditionalBlocks.forEach((block) => {
const textarea = editorRef.current?.querySelector(`[data-block-id="${block.id}"] textarea`)
const textarea = containerRef.current?.querySelector(`[data-block-id="${block.id}"] textarea`)
if (textarea) {
textarea.addEventListener('keydown', (e: Event) => {
if ((e as KeyboardEvent).key === 'Escape') {
Expand Down Expand Up @@ -511,7 +511,7 @@ export function ConditionInput({
}

return (
<div className='space-y-4'>
<div className='space-y-4' ref={containerRef}>
{conditionalBlocks.map((block, index) => (
<div
key={block.id}
Expand Down Expand Up @@ -642,11 +642,7 @@ export function ConditionInput({
{renderLineNumbers(block.id)}
</div>

<div
className='relative mt-0 pt-0 pl-[30px]'
ref={editorRef}
data-block-id={block.id}
>
<div className='relative mt-0 pt-0 pl-[30px]' data-block-id={block.id}>
{block.value.length === 0 && (
<div className='pointer-events-none absolute top-[12px] left-[42px] select-none text-muted-foreground/50'>
{'<response> === true'}
Expand All @@ -656,7 +652,7 @@ export function ConditionInput({
value={block.value}
onValueChange={(newCode) => {
if (!isPreview && !disabled) {
const textarea = editorRef.current?.querySelector(
const textarea = containerRef.current?.querySelector(
`[data-block-id="${block.id}"] textarea`
) as HTMLTextAreaElement | null
if (textarea) {
Expand Down