improvement(ui/ux): logs #762
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR enhances the logs page by adding a contextual filtering sidebar component. The main change introduces a new floating panel in the sidebar that appears specifically when users are on the logs page (/w/.*/logs). The implementation adds:
-
Logs Page Detection: Uses regex pattern matching to detect when users are viewing the logs page, following the same approach used for other contextual UI elements in the sidebar.
-
Contextual Filter Panel: Creates a new floating panel positioned between the toolbar and navigation areas that contains dedicated log filtering controls. The panel uses the same dynamic positioning system as existing floating elements, ensuring consistent behavior when the sidebar is collapsed or expanded.
-
LogsFilters Component: A new reusable component that organizes multiple filter types (Timeline, Level, Trigger, Folder, Workflow) within a scrollable container. The component uses a configuration array approach for easy maintenance and follows React best practices with proper key props.
The integration follows established patterns in the codebase - the contextual panel appears only when relevant (similar to how the workflow toolbar shows only on workflow pages) and maintains the same styling and positioning logic as other floating sidebar elements. The component architecture separates concerns well, with individual filter components coordinated by the main LogsFilters component.
Confidence score: 4/5
• This is a safe, well-structured UI enhancement that follows existing patterns
• High confidence due to consistent implementation with established sidebar architecture and proper React patterns
• No files need additional attention - the changes are straightforward and follow good separation of concerns
2 files reviewed, 1 comment
| {/* Floating Logs Filters - Only on logs page */} | ||
| <div | ||
| className={`pointer-events-auto fixed left-4 z-50 w-56 rounded-[14px] border bg-card shadow-xs ${ | ||
| !isOnLogsPage || isSidebarCollapsed ? 'hidden' : '' | ||
| }`} | ||
| style={{ | ||
| top: `${toolbarTop}px`, | ||
| bottom: `${navigationBottom + 42 + 12}px`, // Navigation height + gap | ||
| }} | ||
| > | ||
| <LogsFilters /> | ||
| </div> |
There was a problem hiding this comment.
style: Consider extracting the dynamic positioning and conditional rendering logic into a reusable hook since it's now duplicated between the toolbar and logs filters components.
There was a problem hiding this comment.
Greptile Summary
This PR makes improvements to the logs page UI/UX, though no specific file changes are visible in the current diff. Based on the PR description and context, this appears to be a continuation of previous work that added a contextual filtering sidebar for the logs page. The changes likely include refinements to the existing logs interface, potentially addressing user experience issues or adding additional functionality to the logs filtering system that was previously introduced.
The improvement builds upon the established logs page architecture that includes contextual filtering panels, timeline controls, and level-based filtering. Given that this is marked as a "new feature" that adds functionality, it likely extends the existing logs interface with additional capabilities or enhanced user interactions.
PR Description Notes:
- Several checklist items remain unchecked, including style guidelines compliance, self-review, code commenting, and test coverage
- Security considerations checklist is also incomplete
Confidence score: 3/5
• Moderate confidence due to lack of visible changes in the current diff, making it difficult to assess the actual implementation
• Score reflects uncertainty about what specific improvements were made and whether they introduce any issues
• All files would benefit from review since no specific changes are visible to evaluate
No files reviewed, no comments
emir-karabeg
force-pushed
the
improvement/logs
branch
from
e24c36c to
6b48ecb
Compare
* improvement: filters ui/ux and logic complete * improvement(ui/ux): logs control bar * improvement(ui): log table * improvement: logs sidebar * ran lint
Description
Improved the logs page.
Type of change
Checklist:
bun run test)Security Considerations: