Skip to content

fix(webhooks): readd immediate acks #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 1 commit into from
Jul 23, 2025
Merged

fix(webhooks): readd immediate acks #771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions apps/sim/lib/webhooks/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,35 +1475,39 @@ export async function processWebhook(
return new NextResponse('No messages in WhatsApp payload', { status: 200 })
}

// --- Execute Workflow ---
// --- Send immediate acknowledgment and execute workflow asynchronously ---
logger.info(
`[${requestId}] Executing workflow ${foundWorkflow.id} for webhook ${foundWebhook.id} (Execution: ${executionId})`
`[${requestId}] Acknowledging webhook ${foundWebhook.id} and executing workflow ${foundWorkflow.id} asynchronously (Execution: ${executionId})`
)

await executeWorkflowFromPayload(
// Execute workflow asynchronously without waiting for completion
executeWorkflowFromPayload(
foundWorkflow,
input,
executionId,
requestId,
foundWebhook.blockId
)

// Since executeWorkflowFromPayload handles logging and errors internally,
// we just need to return a standard success response for synchronous webhooks.
// Note: The actual result isn't typically returned in the webhook response itself.
).catch((error) => {
// Log any errors that occur during async execution
logger.error(
`[${requestId}] Error during async workflow execution for webhook ${foundWebhook.id} (Execution: ${executionId})`,
error
)
})

// Return immediate acknowledgment to the webhook provider
// For Microsoft Teams outgoing webhooks, return the expected response format
if (foundWebhook.provider === 'microsoftteams') {
return NextResponse.json(
{
type: 'message',
text: 'Webhook processed successfully',
text: 'Sim Studio',
},
{ status: 200 }
)
}

return NextResponse.json({ message: 'Webhook processed' }, { status: 200 })
return NextResponse.json({ message: 'Webhook received' }, { status: 200 })
} catch (error: any) {
// Catch errors *before* calling executeWorkflowFromPayload (e.g., auth errors)
logger.error(
Expand All @@ -1516,7 +1520,7 @@ export async function processWebhook(
return NextResponse.json(
{
type: 'message',
text: 'Webhook processing failed',
text: 'Request received but processing failed',
},
{ status: 200 }
) // Still return 200 to prevent Teams from showing additional error messages
Expand Down