Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Description

Remove unused workflow_execution_blocks table since block executions are part of trace spans.

Type of change

  • Code refactoring (no functional changes)

How Has This Been Tested?

Test regular execution and make sure logs show up.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 6:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 24, 2025 6:30pm

@vercel vercel bot temporarily deployed to Preview – docs July 24, 2025 18:26 Inactive
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR removes the unused workflow_execution_blocks table from the database schema as part of a cleanup effort. The change involves three main components:

  1. Schema removal: The workflowExecutionBlocks table definition is completely removed from apps/sim/db/schema.ts. This table previously tracked detailed execution information for individual workflow blocks, including status, timing data, cost metrics, token usage, and input/output data, along with 8 performance indexes.

  2. Database migration: A new migration (0061) is created that executes DROP TABLE "workflow_execution_blocks" CASCADE; to remove the table and all its dependencies from the database.

  3. Migration journal update: The migration journal is updated to track this new migration entry.

According to the PR description, this table became redundant because block execution tracking has been migrated to use trace spans instead. This architectural shift consolidates execution tracking into a more unified tracing system, eliminating the need for a separate table to store block-level execution metadata. The change represents a cleanup of legacy infrastructure that's no longer needed after the migration to the trace spans approach.

Confidence score: 3/5

  • This PR appears safe to merge as it removes genuinely unused infrastructure without affecting active functionality.
  • The score reflects potential concerns about ensuring all application code has been fully migrated away from the old table before this cleanup runs.
  • Files that need more attention: apps/sim/db/migrations/meta/0061_snapshot.json - verify no application code still references the removed table structure.

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@icecrasher321 icecrasher321 merged commit 386644e into staging Jul 24, 2025
4 of 5 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/cleanup-1 branch July 27, 2025 01:34
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…ioai#778)

* improvement(cleanup): remove workflow_execution_blocks table

* remove reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants