Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Description

Remove old logging system. Tests, Routes, execution-logger.ts

Type of change

  • Code refactoring (no functional changes)

How Has This Been Tested?

Run executions -- nothing should change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 7:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 24, 2025 7:50pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR removes the deprecated logging system from the codebase as part of a technical debt cleanup effort. The changes systematically eliminate the old workflow_logs table and its associated infrastructure while maintaining the newer enhanced logging system.

Key Changes:

  • Database Schema: Removes the workflow_logs table through migration 0062, which drops the table with CASCADE to handle all dependencies
  • Test Cleanup: Removes mocks for deprecated persistExecutionLogs and persistExecutionError functions from @/lib/logs/execution-logger across multiple test files
  • Code Comments: Updates references from old logging system to "enhanced logging system" in route handlers

How it Integrates with the Codebase:
The application has evolved from a simple logging approach using the workflow_logs table (which stored basic execution logs with level, message, and metadata) to a more sophisticated system using workflow_execution_logs and workflow_execution_snapshots tables. The newer system provides structured execution tracking with detailed metrics, cost information, block-level statistics, and better performance indexing. This cleanup consolidates on the enhanced logging architecture that uses EnhancedLoggingSession and enhancedExecutionLogger throughout the codebase.

The changes affect test utilities, API route tests, database schema, and migration history while preserving all functional execution logging capabilities through the retained enhanced logging system.

Confidence score: 4/5

  • This PR is generally safe to merge with minimal risk of breaking existing functionality
  • The score reflects the significant database schema change and comprehensive removal of deprecated code across multiple files
  • The migration file 0062_previous_phantom_reporter.sql needs careful attention to ensure the CASCADE operation doesn't affect unexpected dependencies

9 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@icecrasher321 icecrasher321 merged commit 022a61b into staging Jul 24, 2025
5 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/cleanup-old-logging-system branch July 27, 2025 01:34
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants