Skip to content

fix(teams): no immediate acks for ms teams webhook #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 1 commit into from
Jul 28, 2025
Merged

fix(teams): no immediate acks for ms teams webhook #805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 14 additions & 53 deletions apps/sim/lib/webhooks/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ export async function executeWorkflowFromPayload(
workflowVariables
)

// Set up logging on the executor
// Set up logging on the executor
loggingSession.setupExecutor(executor)

// Log workflow execution start time for tracking
Expand Down Expand Up @@ -1432,45 +1432,6 @@ export async function fetchAndProcessAirtablePayloads(
/**
* Process webhook verification and authorization
*/
/**
* Handle Microsoft Teams webhooks with immediate acknowledgment
*/
async function processMicrosoftTeamsWebhook(
foundWebhook: any,
foundWorkflow: any,
input: any,
executionId: string,
requestId: string
): Promise<NextResponse> {
logger.info(
`[${requestId}] Acknowledging Microsoft Teams webhook ${foundWebhook.id} and executing workflow ${foundWorkflow.id} asynchronously (Execution: ${executionId})`
)

// Execute workflow asynchronously without waiting for completion
executeWorkflowFromPayload(
foundWorkflow,
input,
executionId,
requestId,
foundWebhook.blockId
).catch((error) => {
// Log any errors that occur during async execution
logger.error(
`[${requestId}] Error during async workflow execution for webhook ${foundWebhook.id} (Execution: ${executionId})`,
error
)
})

// Return immediate acknowledgment for Microsoft Teams
return NextResponse.json(
{
type: 'message',
text: 'Sim Studio',
},
{ status: 200 }
)
}

/**
* Handle standard webhooks with synchronous execution
*/
Expand All @@ -1494,8 +1455,18 @@ async function processStandardWebhook(
)

// Since executeWorkflowFromPayload handles logging and errors internally,
// we just need to return a standard success response for synchronous webhooks.
// Note: The actual result isn't typically returned in the webhook response itself.
// we just need to return a success response for synchronous webhooks.
// Microsoft Teams requires a specific response format.

if (foundWebhook.provider === 'microsoftteams') {
return NextResponse.json(
{
type: 'message',
text: 'Sim Studio',
},
{ status: 200 }
)
}

return NextResponse.json({ message: 'Webhook processed' }, { status: 200 })
}
Expand Down Expand Up @@ -1564,17 +1535,7 @@ export async function processWebhook(
return new NextResponse('No messages in WhatsApp payload', { status: 200 })
}

// --- Route to appropriate processor based on provider ---
if (foundWebhook.provider === 'microsoftteams') {
return await processMicrosoftTeamsWebhook(
foundWebhook,
foundWorkflow,
input,
executionId,
requestId
)
}

// --- Route to standard processor for all providers ---
return await processStandardWebhook(foundWebhook, foundWorkflow, input, executionId, requestId)
} catch (error: any) {
return handleWebhookError(error, foundWebhook, executionId, requestId)
Expand Down