runtime: Use proper usize type for lengths #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardliner66
force-pushed
the
fix_code_for_armv7
branch
4 times, most recently
from
6d2456f to
1f10cd3
Compare
|
If you rebase this on master, it should show the relevant change only. :) |
hardliner66
force-pushed
the
fix_code_for_armv7
branch
from
1f10cd3 to
3a71d9e
Compare
hardliner66
changed the title
|
Rebased onto master. |
sin-ack
requested changes
Aug 9, 2023
hardliner66
force-pushed
the
fix_code_for_armv7
branch
from
3a71d9e to
434da96
Compare
hardliner66
commented
Aug 9, 2023
|
I also updated the vendored dependency. That should have already been part of the 0.11.0 update, but it kinda fell through. |
|
Sorry for taking so long to look at a trivial patch. I'll give this a lookover tomorrow, I promise. 🙇♂️ |
Don't worry about it. :) |
sin-ack
requested changes
Sep 25, 2023
hardliner66
force-pushed
the
fix_code_for_armv7
branch
from
c7b580b to
8739a28
Compare
|
I fixed the error texts and rebased onto master. |
sin-ack
requested changes
Sep 26, 2023
hardliner66
force-pushed
the
fix_code_for_armv7
branch
2 times, most recently
from
6902558 to
4af0346
Compare
hardliner66
force-pushed
the
fix_code_for_armv7
branch
from
4af0346 to
fd56486
Compare
hardliner66
changed the title
|
@sin-ack Squashed the commits into one |
sin-ack
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the used integer types to
usizefor cases where it should be platform dependent, in order to compilezigselffor other platforms likearmv7.Depends on #25.