Feat/allow to init client without providing parameters #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
Dovchik
changed the title
asein-sinch
approved these changes
Feb 19, 2024
Dovchik
deleted the
feat/allow-to-init-client-without-providing-valid-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
projectIdto first place as a param.Allow initialization of sinchClient Voice or Verification without settings params projectId, keyid and keysecret.
I would like to still have just one constructor for SinchClient to make an accent on unified credentials.
Add example on how to init Voice or Verification client
When accessing products which relies on unified credentials - Sms, Numbers, Conversation, Auth - without providing them , an aggregate exception will be thrown.