Feat/conversation templates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
asein-sinch
reviewed
Mar 12, 2024
|
Is there another PR coming to support Template V1 ? |
I haven't planned V1 support yet |
asein-sinch
reviewed
Mar 12, 2024
| Reference = "12345", | ||
| Source = Source.Intercepted, | ||
| Status = VerificationStatus.Fail | ||
| Reason = new Reason("some_string_value"), |
There was a problem hiding this comment.
Why updating all the fields with values different from the enums defined in the documentation or not meaningful ?
It would be better to update the mocks instead
There was a problem hiding this comment.
It's a mock from oas file, and need to update example which can take some time
asein-sinch
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements TemplatesV2
CI blocked by: #43