Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(voice): refs? #53

Merged
merged 43 commits into from
Apr 23, 2024
Merged

refactor(voice): refs? #53

merged 43 commits into from
Apr 23, 2024

Conversation

Dovchik
Copy link
Contributor

@Dovchik Dovchik commented Apr 12, 2024

For models any non-required/optional field is nullable

Add EmptyResponse class for empty responses from the API, refactor api calls to use it

@Dovchik Dovchik changed the base branch from feat/enable-nullable-reference-types to main April 19, 2024 08:47
@Dovchik Dovchik marked this pull request as ready for review April 19, 2024 10:50
Copy link

@asein-sinch asein-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. I checked the parts related to Conversation and SMS too, even if the PR mentioned voice only

Sinch.sln.DotSettings Outdated Show resolved Hide resolved
src/Sinch/Conversation/Apps/Apps.cs Show resolved Hide resolved
src/Sinch/Core/Http.cs Outdated Show resolved Hide resolved
src/Sinch/Voice/Calls/Call.cs Show resolved Hide resolved
@Dovchik Dovchik requested a review from asein-sinch April 23, 2024 09:27
@Dovchik Dovchik changed the title Refactor/nullable ref types voice refactor(voice): refs? Apr 23, 2024
Dovchik added 4 commits April 23, 2024 10:08
* refactor(verification): refs?
* refactor(sms): refs?
* refactor(numbers): refs?
* refactor(conversation): refs?

* fix: analyzer warns
@Dovchik Dovchik merged commit dcf4493 into main Apr 23, 2024
3 checks passed
@Dovchik Dovchik deleted the refactor/nullable-ref-types-voice branch April 23, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants