Refactor/unify oneofs #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update report response model with new data
…d report responses
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
JPPortier
reviewed
May 6, 2024
| CurrencyId = "EUR" | ||
| }, | ||
| BillableDuration = 40 | ||
| Type = IdentityType.Number, |
There was a problem hiding this comment.
Not related to this PR, just a thought about Identity.
Currently only number is supported.
What do you think about creating something like a dedicated NumberIdentity class to simplify interface with this type ?
e.g. for StartVerification request:
var identity = new NumberIdentity("+123456789");
var request = .... <identity>
It will simplify type usage, hide the protocol dedicated value and in case of new identity type will be supported, it won't cause any breaking change
There was a problem hiding this comment.
yeah, makes sense, I'll add that too after release
JPPortier
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify oneof to be interface typed in a project where it makes sense
Refactor verification to specific methods
Split VerificationReport and VerificationStatus response types
Before merge should be merged: https://github.com/sinch/doppelganger/pull/22