DEVEXP-530: Conversation e2e (alls but templates) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
Base automatically changed from
DEVEXP-530-conversation-e2e-tests
to
feat/conversation
September 2, 2024 09:26
|
@asein-sinch Created DEVEXP-550 regarding the authentication header validation |
* feat (Conversation/e2e): Validate authentication from webhooks * feat (Core): Add guard against 'null' key value for headers comparison
asein-sinch
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note yet templates related test due to pending Temapltes PR in review (will come after)
@asein-sinch About https://github.com/sinch/sinch-sdk-java/blob/DEVEXP-530-conversation-e2e/client/src/test/java/com/sinch/sdk/e2e/domains/conversation/WebhooksEventsSteps.java#L282
We can imagine refining mockerserver/cucumber description with something like
the Conversation event header contains a valid signature for {string}Then tests could use the
{string}identifier to detect which event is having to be checked when running multihtread/parallel mode