Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEXP-565: Add Voice 'Getting Started' code #6

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

asein-sinch
Copy link
Contributor

No description provided.

* @param {Voice.AceRequest} aceRequest - The incoming ACE request object.
* @return {string} The formatted ACE response to handle the answered call.
*/
export const handleAnsweredCallEvent = (aceRequest) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only things I would say for this particular guide is that ACE and PIE will never happen, so it might be overkill and potentially confusing to include them here. Certainly in the server template it makes sense as we want it to be ready for anything, but this particular guide is only for responding to incoming calls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proving your feedback!
I've removed the handling of ACE and PIE. Now there is only ICE, DICE and 'notify'. Should we keep 'notify' or discard it also in the scope of this guide?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it is kind of more advanced functionality, beyond what would be done in a getting started guide. At the very least, with the rest of the configuration in this guide, I don't believe a user would ever receive a notify event as a result of running this app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right. I've removed it too in order to keep this guide as accessible as possible for someone discovering the API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-sberna
Good to know, will update the Java related getting started to be synchronized with this one

Copy link

@alex-sberna alex-sberna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Base automatically changed from DEVEXP-564_Add-Verification-getting-started-code to main September 24, 2024 09:37
@asein-sinch asein-sinch merged commit 225d649 into main Sep 24, 2024
1 check passed
@asein-sinch asein-sinch deleted the DEVEXP-565_Add-Voice-getting-started-code branch September 24, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants