Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEXP-379: Support hostname override in SinchClient parameters #51

Merged

Conversation

asein-sinch
Copy link
Collaborator

Important files to review are the following ones (others are refactoring and linting):

  • *-domain-api.ts
  • *-domain-api.test.ts

@asein-sinch asein-sinch requested a review from a team April 4, 2024 15:46
packages/sms/src/rest/v1/sms-domain-api.ts Show resolved Hide resolved
packages/voice/src/rest/v1/voice-domain-api.ts Outdated Show resolved Hide resolved
packages/voice/src/rest/v1/voice-service.ts Outdated Show resolved Hide resolved
.eslintrc Show resolved Hide resolved
Copy link

@JPPortier JPPortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asein-sinch asein-sinch merged commit 95c6ecc into main Apr 5, 2024
2 checks passed
@asein-sinch asein-sinch deleted the DEVEXP-379_Support-URL-override-in-SinchClient-parameters branch April 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants